Re: [Mingw-w64-public] [PATCH] Revert "headers: Move IP_MREQ from _ip_mreq1.h to ws2ipdef.h."

2021-06-26 Thread Liu Hao
在 6/26/21 6:10 PM, Biswapriyo Nath 写道: Thanks for the explanation. Two questions. 1. If I include winsock.h for ip_mreq it compiles. But if I include winsock2.h for ip_mreq it does not compile. Does winsock2.h need _ip_mreq1.h to be included? It is necessary to include ws2ipdef.h after winsock

Re: [Mingw-w64-public] [PATCH] Revert "headers: Move IP_MREQ from _ip_mreq1.h to ws2ipdef.h."

2021-06-26 Thread Biswapriyo Nath
Thanks for the explanation. Two questions. 1. If I include winsock.h for ip_mreq it compiles. But if I include winsock2.h for ip_mreq it does not compile. Does winsock2.h need _ip_mreq1.h to be included? 2. If I include winsock.h or winsock2.h for ipv6_mreq neither works. Does ipv6_mreq need same

Re: [Mingw-w64-public] [PATCH] Revert "headers: Move IP_MREQ from _ip_mreq1.h to ws2ipdef.h."

2021-06-26 Thread Liu Hao
在 6/26/21 1:10 PM, Biswapriyo Nath 写道: Forgot the patch file. Thanks. Pushed to master. The Windows 8 SDK actually duplicates the definition of `struct ip_mreq` in both and , so I think it is not valid to remove it there. We have the '_ip_mreq1.h' which is nothing but duplication. This

Re: [Mingw-w64-public] [PATCH] Revert "headers: Move IP_MREQ from _ip_mreq1.h to ws2ipdef.h."

2021-06-25 Thread Biswapriyo Nath
Forgot the patch file. From 57fb78c373e609712ae159ac7b9ed51259afaa4b Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Sat, 26 Jun 2021 10:27:17 +0530 Subject: [PATCH] Revert "headers: Move IP_MREQ from _ip_mreq1.h to ws2ipdef.h." This reverts commit 0c7108c439fcf349ec172843b022ccec5cef5da4 Th

[Mingw-w64-public] [PATCH] Revert "headers: Move IP_MREQ from _ip_mreq1.h to ws2ipdef.h."

2021-06-25 Thread Biswapriyo Nath
My apology for this mistake. I am not sure why this causes build issue in SDL_net https://github.com/msys2/MINGW-packages/issues/8759. /cc Ozkan Sezer ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net