Re: [Mingw-w64-public] [PATCH] msvcrt: Remove "DATA" attributes for _onexit for i386

2018-02-27 Thread Martin Storsjö
On Fri, 9 Feb 2018, Martell Malone wrote: LGTM. This is exactly how I was working around it also. Pushed. // Martin -- Check out the vibrant tech community on one of the world's most engaging tech sites,

Re: [Mingw-w64-public] [PATCH] msvcrt: Remove "DATA" attributes for _onexit for i386

2018-02-09 Thread Martell Malone
LGTM. This is exactly how I was working around it also. On Fri 9 Feb 2018 at 01:11, Martin Storsjö wrote: > There is no local wrapper function named _onexit in libmsvcrt.a > or libmingwex.a, and the declaration in headers don't include > any dllimport declaration. > > This

[Mingw-w64-public] [PATCH] msvcrt: Remove "DATA" attributes for _onexit for i386

2018-02-09 Thread Martin Storsjö
There is no local wrapper function named _onexit in libmsvcrt.a or libmingwex.a, and the declaration in headers don't include any dllimport declaration. This makes i386 match the other architectures, and fixes linking to this function with lld. (GNU ld manages to resolve calls to _onexit into