Re: [Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-05-02 Thread Martin Storsjö
On Sun, 1 May 2022, LIU Hao wrote: On Sun, 1 May 2022, JonY via Mingw-w64-public wrote: I think dllexport should be replaced by dllimport in the above statement. Yes it was a typo. Revised patch attached. On Sun, May 1, 2022 at 9:36 AM Martin Storsjö wrote: FWIW, I think this will

Re: [Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-05-01 Thread LIU Hao
On Sun, 1 May 2022, JonY via Mingw-w64-public wrote: I think dllexport should be replaced by dllimport in the above statement. Yes it was a typo. Revised patch attached. On Sun, May 1, 2022 at 9:36 AM Martin Storsjö wrote: FWIW, I think this will break a number of users, who currently

Re: [Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-05-01 Thread JonY via Mingw-w64-public
On 5/1/22 07:55, Vincent Torri wrote: But if you really really prefer this setup, then fine, go ahead. But I did warn that it will inconvenirnce users. should winpthread be used by users ? i thought it was written for c++11 threads Vincent Torri You can still use winpthreads directly, it

Re: [Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-05-01 Thread Vincent Torri
On Sun, May 1, 2022 at 9:36 AM Martin Storsjö wrote: > > On Sun, 1 May 2022, JonY via Mingw-w64-public wrote: > > > On 5/1/22 05:19, LIU Hao wrote: > >> 在 2022-05-01 13:15, LIU Hao 写道: > >>> This is the alternative patch as discussed with jon_y on IRC. > >>> > >>> > >> > >> I forgot to update the

Re: [Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-05-01 Thread Martin Storsjö
On Sun, 1 May 2022, JonY via Mingw-w64-public wrote: On 5/1/22 05:19, LIU Hao wrote: 在 2022-05-01 13:15, LIU Hao 写道: This is the alternative patch as discussed with jon_y on IRC. I forgot to update the commit message. Here is the revised patch. +Programs are usually linked against the

Re: [Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-05-01 Thread JonY via Mingw-w64-public
On 5/1/22 05:19, LIU Hao wrote: 在 2022-05-01 13:15, LIU Hao 写道: This is the alternative patch as discussed with jon_y on IRC. I forgot to update the commit message. Here is the revised patch. +Programs are usually linked against the winpthreads DLL, and winpthreads +headers expose

Re: [Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-04-30 Thread LIU Hao
在 2022-05-01 13:15, LIU Hao 写道: This is the alternative patch as discussed with jon_y on IRC. I forgot to update the commit message. Here is the revised patch. -- Best regards, LIU Hao From 6ffe0530e0838154bab1dda27596d7c0b207790c Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Sat, 30 Apr

[Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-04-30 Thread LIU Hao
This is the alternative patch as discussed with jon_y on IRC. -- Best regards, LIU Hao From 1d0e08852d702232eca5edd885187b7db3074348 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Sat, 30 Apr 2022 21:17:38 +0800 Subject: [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

[Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-04-30 Thread LIU Hao
This is not a satisfactory solution. We can see that after this commit, user code will always see `WINPTHREAD_API` as empty. I prefer to move it from headers to source files. -- Best regards, LIU Hao From cd7156e5e72c8697e5a50da8f7df65e551e6006d Mon Sep 17 00:00:00 2001 From: LIU Hao Date: