Re: [Mingw-w64-public] [PATCH 1/2] crt: Define _CRTBLD in AM_CFLAGS instead of AM_CPPFLAGS

2017-11-10 Thread Martin Storsjö
On Fri, 10 Nov 2017, JonY via Mingw-w64-public wrote: On 11/10/2017 09:03 AM, Martin Storsjö wrote: Libraries that override CPPFLAGS (like lib32_libmsvcrt_a_CPPFLAGS) don't get AM_CPPFLAGS included automatically. We shouldn't add it to the CPPFLAGS32 variable that gets used there, because then

Re: [Mingw-w64-public] [PATCH 1/2] crt: Define _CRTBLD in AM_CFLAGS instead of AM_CPPFLAGS

2017-11-10 Thread JonY via Mingw-w64-public
On 11/10/2017 09:03 AM, Martin Storsjö wrote: > Libraries that override CPPFLAGS (like lib32_libmsvcrt_a_CPPFLAGS) > don't get AM_CPPFLAGS included automatically. We shouldn't add it > to the CPPFLAGS32 variable that gets used there, because then it > would get added twice for the object files that

[Mingw-w64-public] [PATCH 1/2] crt: Define _CRTBLD in AM_CFLAGS instead of AM_CPPFLAGS

2017-11-10 Thread Martin Storsjö
Libraries that override CPPFLAGS (like lib32_libmsvcrt_a_CPPFLAGS) don't get AM_CPPFLAGS included automatically. We shouldn't add it to the CPPFLAGS32 variable that gets used there, because then it would get added twice for the object files that use the explicit COMPILE macro (which already include