Re: [Mingw-w64-public] [PATCH 2/6] headers: Use _get_environ on all CRT versions except UCRT on ARM

2019-05-06 Thread Jacek Caban
On 5/6/19 1:08 PM, Martin Storsjö wrote: On Mon, 6 May 2019, Jacek Caban wrote: On 5/6/19 11:18 AM, Martin Storsjö wrote: UCRT is handled in a separate ifdef further above. The patch looks good, but I'm curious about possible future changes. It seems tempting to use UCRT variant for all

Re: [Mingw-w64-public] [PATCH 2/6] headers: Use _get_environ on all CRT versions except UCRT on ARM

2019-05-06 Thread Martin Storsjö
On Mon, 6 May 2019, Jacek Caban wrote: On 5/6/19 11:18 AM, Martin Storsjö wrote: UCRT is handled in a separate ifdef further above. The patch looks good, but I'm curious about possible future changes. It seems tempting to use UCRT variant for all crts (except problematic ARMs that have

Re: [Mingw-w64-public] [PATCH 2/6] headers: Use _get_environ on all CRT versions except UCRT on ARM

2019-05-06 Thread Jacek Caban
On 5/6/19 11:18 AM, Martin Storsjö wrote: UCRT is handled in a separate ifdef further above. The patch looks good, but I'm curious about possible future changes. It seems tempting to use UCRT variant for all crts (except problematic ARMs that have dedicated branch anyway) to unify builds

[Mingw-w64-public] [PATCH 2/6] headers: Use _get_environ on all CRT versions except UCRT on ARM

2019-05-06 Thread Martin Storsjö
UCRT is handled in a separate ifdef further above. Signed-off-by: Martin Storsjö --- mingw-w64-headers/crt/stdlib.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mingw-w64-headers/crt/stdlib.h b/mingw-w64-headers/crt/stdlib.h index 45f03807a..a8cc106df 100644 ---