Re: [Mingw-w64-public] [PATCH] headers: Implement the conio.h printf/scanf functions for ucrtbase

2017-11-24 Thread Jacek Caban
Hi Martin, On 11/24/17 11:03 AM, Martin Storsjö wrote: --- mingw-w64-headers/crt/conio.h | 214 +- 1 file changed, 209 insertions(+), 5 deletions(-) Since we already know that we often need such functions in libucrtbase.a, wouldn't it make more

[Mingw-w64-public] [PATCHv2] headers: Implement the conio.h printf/scanf functions for ucrtbase

2017-11-24 Thread Martin Storsjö
Some declarations were moved slightly, to reduce the amount of ifdeffing needed. I only provide the same set of functions as before, not (yet?) the full set of functions possible with the ucrtbase common functions. Signed-off-by: Martin Storsjö --- v2: Fixed the parameter to

Re: [Mingw-w64-public] [PATCH] headers: Implement the conio.h printf/scanf functions for ucrtbase

2017-11-24 Thread Martin Storsjö
On Fri, 24 Nov 2017, Jacek Caban wrote: Hi Martin, On 11/24/17 11:03 AM, Martin Storsjö wrote: --- mingw-w64-headers/crt/conio.h | 214 +- 1 file changed, 209 insertions(+), 5 deletions(-) Since we already know that we often need such functions

Re: [Mingw-w64-public] [PATCH] ucrtbase: Make sure that compat symbols aren't autoexported

2017-11-24 Thread Martin Storsjö
On Thu, 23 Nov 2017, Sven Kretzschmar wrote: I will try to add the 2 missing references in the way you hinted at in your post. FWIW, for the _cprintf one, the conio.h patch that I sent should be a proper fix. The other one requires fixing stdio_s.h, and it's a truly huge number of

Re: [Mingw-w64-public] [PATCH 1/2] Remove vsnprintf forward from libmingwex.

2017-11-24 Thread Martin Storsjö
On Fri, 24 Nov 2017, Jacek Caban wrote: It's properly forwarded by crt import libs. Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/stdio/vsnprintf.c | 13 - 2 files changed, 1 insertion(+), 14 deletions(-) delete mode

Re: [Mingw-w64-public] [PATCH 2/2] Use .def files to forward vsnprintf_s to _vsnprintf_s.

2017-11-24 Thread Martin Storsjö
On Fri, 24 Nov 2017, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/def-include/msvcrt-common.def.in | 2 ++ mingw-w64-crt/stdio/vsnprintf_s.c | 16 3 files changed, 3

[Mingw-w64-public] [PATCH 2/2] Use .def files to forward vsnprintf_s to _vsnprintf_s.

2017-11-24 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/def-include/msvcrt-common.def.in | 2 ++ mingw-w64-crt/stdio/vsnprintf_s.c | 16 3 files changed, 3 insertions(+), 17 deletions(-) delete

Re: [Mingw-w64-public] [PATCH 1/2] corecrt_startup.h: Added a new file with _acmdln and _wcmdln declarations.

2017-11-24 Thread Martin Storsjö
On Fri, 24 Nov 2017, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-headers/crt/corecrt_startup.h | 23 +++ mingw-w64-headers/crt/process.h | 1 + 2 files changed, 24 insertions(+) create mode 100644

Re: [Mingw-w64-public] [PATCH 2/2] Use public _acmdln and _wcmdln declarations in crt and get rid of no loner needed ucrtbase compat hack.

2017-11-24 Thread Martin Storsjö
On Fri, 24 Nov 2017, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/crt/ucrtbase_compat.c | 8 mingw-w64-crt/include/internal.h| 12 2 files changed, 20 deletions(-) Nice, thanks! Signed-off-by: Martin Storsjö

Re: [Mingw-w64-public] [PATCH 1/2] Remove vsnprintf forward from libmingwex.

2017-11-24 Thread Jacek Caban
On 24.11.2017 20:45, Martin Storsjö wrote: > On Fri, 24 Nov 2017, Jacek Caban wrote: > >> >> It's properly forwarded by crt import libs. >> >> Signed-off-by: Jacek Caban >> --- >> mingw-w64-crt/Makefile.am   |  2 +- >> mingw-w64-crt/stdio/vsnprintf.c | 13 -

Re: [Mingw-w64-public] [PATCH] headers: Implement the conio.h printf/scanf functions for ucrtbase

2017-11-24 Thread Martin Storsjö
On Fri, 24 Nov 2017, Jacek Caban wrote: On 24.11.2017 11:37, Martin Storsjö wrote: MSVC doesn't provide these functions as global symbols at the linker level, but there you must include a header to make them work. Additionally, for the wchar versions, you can currently override the behaviour

Re: [Mingw-w64-public] [PATCH] headers: Implement the conio.h printf/scanf functions for ucrtbase

2017-11-24 Thread Jacek Caban
On 24.11.2017 11:37, Martin Storsjö wrote: > MSVC doesn't provide these functions as global symbols at the linker > level, but there you must include a header to make them work. > > Additionally, for the wchar versions, you can currently override the > behaviour by setting

[Mingw-w64-public] __MINGW_GNUC_PREREQ vs clang

2017-11-24 Thread Mateusz Mikuła
Clang defines itself as GCC 4.2.1 which can cause issues like multiple definitions of `__m64`, `__m128`, ... coming from crt/intrin.h when `-march=i686` is used when building compiler-rt. When I override it for clang to return false compiler-rt builds fine with `-march=i686`. I think it's a good

[Mingw-w64-public] [PATCH 1/2] Remove vsnprintf forward from libmingwex.

2017-11-24 Thread Jacek Caban
It's properly forwarded by crt import libs. Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/stdio/vsnprintf.c | 13 - 2 files changed, 1 insertion(+), 14 deletions(-) delete mode 100644 mingw-w64-crt/stdio/vsnprintf.c

[Mingw-w64-public] [PATCH 1/2] corecrt_startup.h: Added a new file with _acmdln and _wcmdln declarations.

2017-11-24 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-headers/crt/corecrt_startup.h | 23 +++ mingw-w64-headers/crt/process.h | 1 + 2 files changed, 24 insertions(+) create mode 100644 mingw-w64-headers/crt/corecrt_startup.h diff --git

[Mingw-w64-public] [PATCH 2/2] Use public _acmdln and _wcmdln declarations in crt and get rid of no loner needed ucrtbase compat hack.

2017-11-24 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/crt/ucrtbase_compat.c | 8 mingw-w64-crt/include/internal.h| 12 2 files changed, 20 deletions(-) diff --git a/mingw-w64-crt/crt/ucrtbase_compat.c b/mingw-w64-crt/crt/ucrtbase_compat.c index