Re: [Mingw-w64-public] [PATCH 01/19] math: Add errors in assembly sources if no implementation exists

2017-08-08 Thread Martin Storsjö
On Mon, 7 Aug 2017, Martin Storsjö wrote: On Sun, 6 Aug 2017, JonY via Mingw-w64-public wrote: On 08/06/2017 02:59 PM, David Grayson wrote: I would agree with Martin; I think it's a very good practice for source files to have an error or not define a function instead of defining a function

Re: [Mingw-w64-public] [PATCH 01/19] math: Add errors in assembly sources if no implementation exists

2017-08-07 Thread Martin Storsjö
On Sun, 6 Aug 2017, JonY via Mingw-w64-public wrote: On 08/06/2017 02:59 PM, David Grayson wrote: I would agree with Martin; I think it's a very good practice for source files to have an error or not define a function instead of defining a function that can't possibly work and letting the

Re: [Mingw-w64-public] [PATCH 01/19] math: Add errors in assembly sources if no implementation exists

2017-08-06 Thread JonY via Mingw-w64-public
On 08/06/2017 02:59 PM, David Grayson wrote: > I would agree with Martin; I think it's a very good practice for > source files to have an error or not define a function instead of > defining a function that can't possibly work and letting the build > proceed with a broken function. Compiler and

Re: [Mingw-w64-public] [PATCH 01/19] math: Add errors in assembly sources if no implementation exists

2017-08-06 Thread David Grayson
I would agree with Martin; I think it's a very good practice for source files to have an error or not define a function instead of defining a function that can't possibly work and letting the build proceed with a broken function. Compiler and linker errors are much easier to figure out than

Re: [Mingw-w64-public] [PATCH 01/19] math: Add errors in assembly sources if no implementation exists

2017-08-06 Thread Martin Storsjö
On Sun, 6 Aug 2017, JonY via Mingw-w64-public wrote: On 08/05/2017 09:14 PM, Martin Storsjö wrote: This helps finding unimplemented functions; otherwise the symbol will exist, but won't contain any implementation, so the function will end up pointing at whatever other function the linker

Re: [Mingw-w64-public] [PATCH 01/19] math: Add errors in assembly sources if no implementation exists

2017-08-05 Thread JonY via Mingw-w64-public
On 08/05/2017 09:14 PM, Martin Storsjö wrote: > This helps finding unimplemented functions; otherwise the symbol > will exist, but won't contain any implementation, so the function > will end up pointing at whatever other function the linker places > next. I would prefer these checks be in the

[Mingw-w64-public] [PATCH 01/19] math: Add errors in assembly sources if no implementation exists

2017-08-05 Thread Martin Storsjö
This helps finding unimplemented functions; otherwise the symbol will exist, but won't contain any implementation, so the function will end up pointing at whatever other function the linker places next. --- mingw-w64-crt/math/_chgsignl.S | 2 ++ mingw-w64-crt/math/ceil.S | 2 ++