Re: [Mingw-w64-public] [PATCH] Fix gendef fallthroughts and enable winpthreads library build

2017-10-07 Thread JonY via Mingw-w64-public 
On 10/06/2017 02:04 PM, Martell Malone wrote:
> The winpthreads patch LGTM.
> Will need someone else to approve/comment on the gendef patch.

Pushed the winpthreads patch to master, dropped the gendef patch for now.


signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Fix gendef fallthroughts and enable winpthreads library build

2017-10-06 Thread JonY via Mingw-w64-public 
On 10/06/2017 05:40 PM, Ozkan Sezer wrote:
> On 10/6/17, JonY via Mingw-w64-public
>  wrote:
>> Patches OK?
> 
> gendef fallthrough patch looks bogus to me.
> 

Should it follow the patterns more strictly?
https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/


signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Fix gendef fallthroughts and enable winpthreads library build

2017-10-06 Thread Ozkan Sezer 
On 10/6/17, JonY via Mingw-w64-public
 wrote:
> Patches OK?

gendef fallthrough patch looks bogus to me.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Fix gendef fallthroughts and enable winpthreads library build

2017-10-06 Thread Kai Tietz via Mingw-w64-public 
Hello JonY,

the winpthread patch is ok.  But I have to agree that this
"fallthrough feature" of gcc is more or less pretty bad ...

Regards,
Kai

2017-10-06 15:52 GMT+02:00 JonY via Mingw-w64-public
:
> Patches OK?
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Fix gendef fallthroughts and enable winpthreads library build

2017-10-06 Thread Martell Malone 
The winpthreads patch LGTM.
Will need someone else to approve/comment on the gendef patch.

On Fri 6 Oct 2017 at 06:54, JonY via Mingw-w64-public <
mingw-w64-public@lists.sourceforge.net> wrote:

> Patches OK?
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public