Re: [Mingw-w64-public] [PATCH 0/7] Ucrtbase/__argv/__p___* functions

[Kai Tietz via Mingw-w64-public]

2017-11-09 9:18 GMT+01:00 Martin Storsjö :
> On Thu, 9 Nov 2017, Jacek Caban wrote:
>
>> On 08.11.2017 23:19, Martin Storsjö wrote:
>>>
>>> - Fix getopt by using __p___argv there instead of __argv, as Jacek
>>>   suggested. In order to do this, I ended up cleaning up a few other
>>>   inconsistencies surrounding the build of msvcr* dlls/defs while
>>>   I was touching that area, cleanly separated in different fixes.
>>
>>
>>
>> Thank you for doing that, it looks much better now.
>>
>>
>> BTW, similar solution could be used for other cases where compat is
>> questionable otherwise. I'm mostly thinking about providing
>> __acrt_iob_func in all libmsvcr* libraries and always using it in
>> headers to properly handle stderr and alike.
>
>
> Yes, that might make sense - I think that might fix some other issue I'm
> noticing here - where the getopt implementation in libmingwex tries to do
> fputc(stderr,) with the non-ucrtbase version of stderr.

Yes that sounds like a good approach.

Thanks for your work on this,
Kai

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 0/7] Ucrtbase/__argv/__p___* functions

[Martin Storsjö]

On Thu, 9 Nov 2017, Jacek Caban wrote:


On 08.11.2017 23:19, Martin Storsjö wrote:

- Fix getopt by using __p___argv there instead of __argv, as Jacek
  suggested. In order to do this, I ended up cleaning up a few other
  inconsistencies surrounding the build of msvcr* dlls/defs while
  I was touching that area, cleanly separated in different fixes.



Thank you for doing that, it looks much better now.


BTW, similar solution could be used for other cases where compat is
questionable otherwise. I'm mostly thinking about providing
__acrt_iob_func in all libmsvcr* libraries and always using it in
headers to properly handle stderr and alike.


Yes, that might make sense - I think that might fix some other issue I'm 
noticing here - where the getopt implementation in libmingwex tries to do 
fputc(stderr,) with the non-ucrtbase version of stderr.


// Martin
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 0/7] Ucrtbase/__argv/__p___* functions

[Jacek Caban]

On 08.11.2017 23:19, Martin Storsjö wrote:
> - Fix getopt by using __p___argv there instead of __argv, as Jacek
>   suggested. In order to do this, I ended up cleaning up a few other
>   inconsistencies surrounding the build of msvcr* dlls/defs while
>   I was touching that area, cleanly separated in different fixes.


Thank you for doing that, it looks much better now.


BTW, similar solution could be used for other cases where compat is
questionable otherwise. I'm mostly thinking about providing
__acrt_iob_func in all libmsvcr* libraries and always using it in
headers to properly handle stderr and alike.


Cheers,

Jacek


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public