Re: [Mingw-w64-public] Fix definitions of _daylight/_dstbias/_timezone/_tzname for msvcr*.dll.

2017-11-21 Thread Yuta Nakai
>__MINGW_IMPORT (which expands to dllimport)
ah, that's right. Sorry, I missed that. 
I thought these global variables was declared with extern(w/o dllimport) in the 
samy way as other global variables.



From: Martin Storsjö <mar...@martin.st>
Sent: 21 November 2017 13:43
To: mingw-w64-public@lists.sourceforge.net
Subject: Re: [Mingw-w64-public] Fix definitions of 
_daylight/_dstbias/_timezone/_tzname for msvcr*.dll.

On Tue, 21 Nov 2017, Yuta Nakai wrote:

> Attached patch fixes the definitions of _daylight/_dstbias/_timezone/_tzname 
> for msvcr*.dll.
> These are global variables and exported as DATA symbols,  so we should use 
> __MINGW_IMP_SYMBOL.

In which case do you see an actual difference in behaviour compared to
now, when they are declared with __MINGW_IMPORT (which expands to
dllimport)? I did a quick test with msvcrt.dll and it seemed to work just
fine as it is right now.

// Martin

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


Re: [Mingw-w64-public] Fix definitions of _daylight/_dstbias/_timezone/_tzname for msvcr*.dll.

2017-11-21 Thread Martin Storsjö

On Tue, 21 Nov 2017, Yuta Nakai wrote:


Attached patch fixes the definitions of _daylight/_dstbias/_timezone/_tzname 
for msvcr*.dll.
These are global variables and exported as DATA symbols,  so we should use 
__MINGW_IMP_SYMBOL.


In which case do you see an actual difference in behaviour compared to 
now, when they are declared with __MINGW_IMPORT (which expands to 
dllimport)? I did a quick test with msvcrt.dll and it seemed to work just 
fine as it is right now.


// Martin

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public