在 03/12/2018 11:23 PM, jpmug...@suddenlink.net 写道: > Anyway, the fix adds a macro that I barrowed from Graphite2 and further > modified. >
Graphite2 is LGPL's, so copying code from there is not an option. > > > I hope gets through. > > > > Interestingly enough, part of the issue with tools and compile failures are > part of an attempt to fix the warnings for things like "invalid format" and > fallthroughs. > > Checking `GCC_VERSION` for being > 6.4 does not seem correct. It is not equivalent to checking `GCC_VERSION` for being >= 7.0. > > Idially, there needs to be a common macro that can be shared by tools, crt, > and other libraries included with the package. > > ... The hunks you added were too complex to fit into .c files. They are also heavily duplicated. In addition to that, the warnings can easily be suppressed by adding `/* fallthrough */` which is both clear and effective. So I vote against this patch. > > Let me know if the patch appears in the E-Mail. I tried adding a .txt > extension. Otherwise, we have to find some common way to get these patches > shared without E-Mail. \ > Yes. -- Best regards, LH_Mouse
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
