On 28/11/2019, 12:50, "Stefano Stabellini" wrote:
On Thu, 28 Nov 2019, Jan Beulich wrote:
> On 28.11.2019 01:56, Stefano Stabellini wrote:
> > On Thu, 26 Sep 2019, Lars Kurth wrote:
> > I think a good recommendation would be for the contributor to try to
> > follow the
On 28/11/2019, 12:12, "Rich Persaud" wrote:
On Nov 28, 2019, at 05:12, Jan Beulich wrote:
>
> On 28.11.2019 01:54, Stefano Stabellini wrote:
>>> On Thu, 26 Sep 2019, Lars Kurth wrote:
>>> From: Lars Kurth
>>>
>>> This document highlights what reviewers such as
On 27/11/2019, 18:56, "Stefano Stabellini" wrote:
On Thu, 26 Sep 2019, Lars Kurth wrote:
> From: Lars Kurth
>
> This guide provides Best Practice on identifying and resolving
> common classes of disagreement
>
> Signed-off-by: Lars Kurth
> --
> Cc:
From: Rich Persaud
Date: Thursday, 28 November 2019 at 12:21
To: Lars Kurth
Cc: 'Jan Beulich' , "lars.ku...@xenproject.org"
, Stefano Stabellini ,
"xen-...@lists.xenproject.org" ,
"minios-de...@lists.xenproject.org" ,
"committ...@xenproject.org" ,
"mirageos-devel@lists.xenproject.org" ,
On 27/11/2019, 19:06, "Stefano Stabellini" wrote:
On Fri, 27 Sep 2019, Jan Beulich wrote:
> On 26.09.2019 21:39, Lars Kurth wrote:
> > +### Verbose vs. terse
> > +Due to the time it takes to review and compose code reviewer,
reviewers often adopt a
> > +terse style. It is
On 27/11/2019, 18:57, "Stefano Stabellini" wrote:
On Thu, 26 Sep 2019, Lars Kurth wrote:
> From: Lars Kurth
>
> This guide covers the bulk on Best Practice related to code review
> It primarily focusses on code review interactions
> It also covers how to deal with
On Thu, 28 Nov 2019, Jan Beulich wrote:
> On 28.11.2019 01:56, Stefano Stabellini wrote:
> > On Thu, 26 Sep 2019, Lars Kurth wrote:
> >> +This could take for example the form of
> >> +> Do you think it would be useful for the code to do XXX?
> >> +> I can imagine a user wanting to do YYY (and XXX
On Nov 28, 2019, at 09:05, Lars Kurth wrote:
>
> On 28/11/2019, 07:37, "Jan Beulich" wrote:
>
>>On 28.11.2019 14:06, Lars Kurth wrote:
>> I can certainly add something on the timing , along the lines of
>> * For complex series, consider the time it takes to do reviews (maybe with a
>>
On Thu, 28 Nov 2019, Jan Beulich wrote:
> On 28.11.2019 01:54, Stefano Stabellini wrote:
> > On Thu, 26 Sep 2019, Lars Kurth wrote:
> >> From: Lars Kurth
> >>
> >> This document highlights what reviewers such as maintainers and committers
> >> look
> >> for when reviewing code. It sets
On Nov 28, 2019, at 05:12, Jan Beulich wrote:
>
> On 28.11.2019 01:54, Stefano Stabellini wrote:
>>> On Thu, 26 Sep 2019, Lars Kurth wrote:
>>> From: Lars Kurth
>>>
>>> This document highlights what reviewers such as maintainers and committers
>>> look
>>> for when reviewing code. It sets
On 28/11/2019, 07:37, "Jan Beulich" wrote:
On 28.11.2019 14:06, Lars Kurth wrote:
> I can certainly add something on the timing , along the lines of
> * For complex series, consider the time it takes to do reviews (maybe
with a guide of LOC per hour) and give reviewers enough
On 28.11.2019 14:06, Lars Kurth wrote:
> I can certainly add something on the timing , along the lines of
> * For complex series, consider the time it takes to do reviews (maybe with a
> guide of LOC per hour) and give reviewers enough time to
> * For series with design issues or large questions,
On 28/11/2019, 04:09, "Jan Beulich" wrote:
On 28.11.2019 01:54, Stefano Stabellini wrote:
> On Thu, 26 Sep 2019, Lars Kurth wrote:
>> From: Lars Kurth
>>
>> This document highlights what reviewers such as maintainers and
committers look
>> for when reviewing code. It
On 28.11.2019 01:56, Stefano Stabellini wrote:
> On Thu, 26 Sep 2019, Lars Kurth wrote:
>> +This could take for example the form of
>> +> Do you think it would be useful for the code to do XXX?
>> +> I can imagine a user wanting to do YYY (and XXX would enable this)
>> +
>> +That potentially adds
On 28.11.2019 01:54, Stefano Stabellini wrote:
> On Thu, 26 Sep 2019, Lars Kurth wrote:
>> From: Lars Kurth
>>
>> This document highlights what reviewers such as maintainers and committers
>> look
>> for when reviewing code. It sets expectations for code authors and provides
>> a framework for
15 matches
Mail list logo
