Re: [MirageOS-devel] [Xen-devel] [PATCH v4 7/7] Added Resolving Disagreement

2020-01-06 Thread Jürgen Groß
On 06.01.20 13:54, Lars Kurth wrote: On 06/01/2020, 07:25, "Jürgen Groß" wrote: >+## Issue: Small functional issues >+ >+The most common area of disagreements which happen in code reviews, are >+differing opinions on whether small functional issues in a patch series

Re: [MirageOS-devel] [Xen-devel] [PATCH v4 7/7] Added Resolving Disagreement

2020-01-06 Thread Lars Kurth
On 06/01/2020, 07:25, "Jürgen Groß" wrote: >+## Issue: Small functional issues >+ >+The most common area of disagreements which happen in code reviews, are >+differing opinions on whether small functional issues in a patch series have to >+be resolved or not before the

Re: [MirageOS-devel] [Minios-devel] Setting up a monthly Xen Project dinner/pub-meeting

2020-01-06 Thread Julien Grall
Hi, On 11/12/2019 11:00, Lars Kurth wrote: And this time with the correct list. Really despairing with Outlook which keeps adding random old contacts to my address book and puts them in front of frequently used entries (sigh) *From: *Lars Kurth *Date: *Wednesday, 11 December 2019 at 10:31

Re: [MirageOS-devel] [Xen-devel] [PATCH v4 7/7] Added Resolving Disagreement

2020-01-06 Thread Jürgen Groß
On 30.12.19 20:32, Lars Kurth wrote: From: Lars Kurth This guide provides Best Practice on identifying and resolving common classes of disagreement Changes since v3 * Fixed broken http link (typo) Changes since v2 (added in v2) * Fix typos * Add section: "Issue: Multiple ways to solve a

Re: [MirageOS-devel] [Xen-devel] [PATCH v4 6/7] Add guide on Communication Best Practice

2020-01-06 Thread Jürgen Groß
On 30.12.19 20:32, Lars Kurth wrote: From: Lars Kurth This guide covers the bulk on Best Practice related to code review It primarily focusses on code review interactions It also covers how to deal with Misunderstandings and Cultural Differences Changes since v3 * Fixed typo Changes since v2

Re: [MirageOS-devel] [Xen-devel] [PATCH v4 5/7] Add Code Review Guide

2020-01-06 Thread Jürgen Groß
On 30.12.19 20:32, Lars Kurth wrote: From: Lars Kurth This document highlights what reviewers such as maintainers and committers look for when reviewing code. It sets expectations for code authors and provides a framework for code reviewers. Changes since v3 * Added example under *Workflow

Re: [MirageOS-devel] [Xen-devel] [PATCH v4 4/7] Add Communication Guide

2020-01-06 Thread Jürgen Groß
On 30.12.19 20:32, Lars Kurth wrote: From: Lars Kurth This document is a portal page that lays out our gold standard, best practices for some common situations and mechanisms to help resolve issues that can have a negative effect on our community. Detail is covered in subsequent documents