On 06/12/2019, 09:51, "Jan Beulich" wrote:
On 06.12.2019 00:41, Lars Kurth wrote:
> I propose to add the following section to code-review-guide.md
>
>
> ## Problematic Patch Reviews
>
> A typical waterfall software development process is sequential with the
On 06.12.2019 00:41, Lars Kurth wrote:
> I propose to add the following section to code-review-guide.md
>
>
> ## Problematic Patch Reviews
>
> A typical waterfall software development process is sequential with the
> following
> steps: define requirements, analyse, design, code, test and
,
"mirageos-devel@lists.xenproject.org" ,
xen-devel , "win-pv-de...@lists.xenproject.org"
Subject: Re: [MirageOS-devel] [PATCH v2 4/6] Add Code Review Guide
On Nov 28, 2019, at 09:05, Lars Kurth wrote:
On 28/11/2019, 07:37, "Jan Beulich" wrote:
On 28.11.2019
On Nov 28, 2019, at 09:05, Lars Kurth wrote:
>
> On 28/11/2019, 07:37, "Jan Beulich" wrote:
>
>>On 28.11.2019 14:06, Lars Kurth wrote:
>> I can certainly add something on the timing , along the lines of
>> * For complex series, consider the time it takes to do reviews (maybe with a
>>
On 28/11/2019, 07:37, "Jan Beulich" wrote:
On 28.11.2019 14:06, Lars Kurth wrote:
> I can certainly add something on the timing , along the lines of
> * For complex series, consider the time it takes to do reviews (maybe
with a guide of LOC per hour) and give reviewers enough
On 28.11.2019 14:06, Lars Kurth wrote:
> I can certainly add something on the timing , along the lines of
> * For complex series, consider the time it takes to do reviews (maybe with a
> guide of LOC per hour) and give reviewers enough time to
> * For series with design issues or large questions,
On Thu, 26 Sep 2019, Lars Kurth wrote:
> From: Lars Kurth
>
> This document highlights what reviewers such as maintainers and committers
> look
> for when reviewing code. It sets expectations for code authors and provides
> a framework for code reviewers.
I think the document is missing a
