Re: [MirageOS-devel] [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

2019-11-28 Thread Lars Kurth
On 28/11/2019, 12:12, "Rich Persaud" wrote: On Nov 28, 2019, at 05:12, Jan Beulich wrote: > > On 28.11.2019 01:54, Stefano Stabellini wrote: >>> On Thu, 26 Sep 2019, Lars Kurth wrote: >>> From: Lars Kurth >>> >>> This document highlights what reviewers such as

Re: [MirageOS-devel] [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

2019-11-28 Thread Stefano Stabellini
On Thu, 28 Nov 2019, Jan Beulich wrote: > On 28.11.2019 01:54, Stefano Stabellini wrote: > > On Thu, 26 Sep 2019, Lars Kurth wrote: > >> From: Lars Kurth > >> > >> This document highlights what reviewers such as maintainers and committers > >> look > >> for when reviewing code. It sets

Re: [MirageOS-devel] [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

2019-11-28 Thread Rich Persaud
On Nov 28, 2019, at 05:12, Jan Beulich wrote: > > On 28.11.2019 01:54, Stefano Stabellini wrote: >>> On Thu, 26 Sep 2019, Lars Kurth wrote: >>> From: Lars Kurth >>> >>> This document highlights what reviewers such as maintainers and committers >>> look >>> for when reviewing code. It sets

Re: [MirageOS-devel] [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

2019-11-28 Thread Lars Kurth
On 28/11/2019, 04:09, "Jan Beulich" wrote: On 28.11.2019 01:54, Stefano Stabellini wrote: > On Thu, 26 Sep 2019, Lars Kurth wrote: >> From: Lars Kurth >> >> This document highlights what reviewers such as maintainers and committers look >> for when reviewing code. It

Re: [MirageOS-devel] [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

2019-11-28 Thread Jan Beulich
On 28.11.2019 01:54, Stefano Stabellini wrote: > On Thu, 26 Sep 2019, Lars Kurth wrote: >> From: Lars Kurth >> >> This document highlights what reviewers such as maintainers and committers >> look >> for when reviewing code. It sets expectations for code authors and provides >> a framework for