Re: OpenBSD Errata: December 11th, 2019 (ldso)

2019-12-14 Thread Theo de Raadt
Antoine Jacoutot wrote: > On Sun, Dec 15, 2019 at 09:07:50AM +1000, Stuart Longland wrote: > > On 15/12/19 9:04 am, Antoine Jacoutot wrote: > > > On Sun, Dec 15, 2019 at 08:43:02AM +1000, Stuart Longland wrote: > > >> On 14/12/19 7:49 pm, Frank Beuth wrote: > > >>> OpenBSD doesn't have unit

Re: OpenBSD Errata: December 11th, 2019 (ldso)

2019-12-14 Thread Antoine Jacoutot
On Sun, Dec 15, 2019 at 09:07:50AM +1000, Stuart Longland wrote: > On 15/12/19 9:04 am, Antoine Jacoutot wrote: > > On Sun, Dec 15, 2019 at 08:43:02AM +1000, Stuart Longland wrote: > >> On 14/12/19 7:49 pm, Frank Beuth wrote: > >>> OpenBSD doesn't have unit tests (or if they are, they're not in

Re: OpenBSD Errata: December 11th, 2019 (ldso)

2019-12-14 Thread Stuart Longland
On 15/12/19 9:04 am, Antoine Jacoutot wrote: > On Sun, Dec 15, 2019 at 08:43:02AM +1000, Stuart Longland wrote: >> On 14/12/19 7:49 pm, Frank Beuth wrote: >>> OpenBSD doesn't have unit tests (or if they are, they're not in the main >>> source tree). How does the project ensure that such

Re: OpenBSD Errata: December 11th, 2019 (ldso)

2019-12-14 Thread Antoine Jacoutot
On Sun, Dec 15, 2019 at 08:43:02AM +1000, Stuart Longland wrote: > On 14/12/19 7:49 pm, Frank Beuth wrote: > > OpenBSD doesn't have unit tests (or if they are, they're not in the main > > source tree). How does the project ensure that such wonderfully quick > > fixes don't introduce new bugs? > >

Re: OpenBSD Errata: December 11th, 2019 (ldso)

2019-12-14 Thread Stuart Longland
On 14/12/19 7:49 pm, Frank Beuth wrote: > OpenBSD doesn't have unit tests (or if they are, they're not in the main > source tree). How does the project ensure that such wonderfully quick > fixes don't introduce new bugs? I think what helps too is the KISS approach taken in the design of the

Third server now locked up after reboot due to no keyboard attached

2019-12-14 Thread Alfred Morgan
I have now another machine running OpenBSD not recover from a reboot. I thought I was having hardware issues with my two other servers (both zbox) and now this third one (Dell) with totally different hardware is having the same problem getting stuck at the boot> prompt. The problem goes away and

Re: [sh] Single quote in comment withing subshell buggy

2019-12-14 Thread Todd C . Miller
On Sat, 14 Dec 2019 09:03:26 +, cho...@jtan.com wrote: > This is certainly not the best way to do this but it does the job: > > In particular it just reeks of kludge, which I'm not happy with > because according to the comment two-dozen lines up it's already a > kludge. The loop is lifted

Re: [sh] Single quote in comment withing subshell buggy

2019-12-14 Thread Richard Ulmer
Hi Matthew, I'm unable to judge the patch, but appreciate your quick fix. Thanks a lot! I'm looking forward to the next release, in which it is contained. I just occurred to me, that the problem also exists for ". Is this covered with your patch as well? Richard cho...@jtan.com wrote: > Richard

Re: OpenBSD Errata: December 11th, 2019 (ldso)

2019-12-14 Thread Otto Moerbeek
On Sat, Dec 14, 2019 at 10:49:31AM +0100, Frank Beuth wrote: > On Wed, Dec 11, 2019 at 01:51:18PM -0500, T.J. Townsend wrote: > > Errata patches for ld.so have been released for OpenBSD 6.5 and 6.6. > > > > ld.so may fail to remove the LD_LIBRARY_PATH environment variable for > > set-user-ID and

Re: regression tests (was: OpenBSD Errata: December 11th, 2019 (ldso))

2019-12-14 Thread Claus Assmann
On Sat, Dec 14, 2019, Frank Beuth wrote: > OpenBSD doesn't have unit tests (or if they are, they're not in the main Hmm, what about src/regress/ ? You are probably welcome to contribute tests :-) -- Address is valid for this mailing list only.

Re: OpenBSD Errata: December 11th, 2019 (ldso)

2019-12-14 Thread Frank Beuth
On Wed, Dec 11, 2019 at 01:51:18PM -0500, T.J. Townsend wrote: Errata patches for ld.so have been released for OpenBSD 6.5 and 6.6. ld.so may fail to remove the LD_LIBRARY_PATH environment variable for set-user-ID and set-group-ID executables in low memory conditions. The security advisory

Re: [sh] Single quote in comment withing subshell buggy

2019-12-14 Thread NilsOla Nilsson
On Sat, Dec 14, 2019 at 09:03:26AM +, cho...@jtan.com wrote: > Richard Ulmer writes: > > Hi, > > when there is a single ' in a comment within a subshell, I get this > > error: foo[6]: no closing quote > > > > Here is an example script to reproduce the problem: > > > > foo=$( > > # It's

Re: [sh] Single quote in comment withing subshell buggy

2019-12-14 Thread chohag
Richard Ulmer writes: > Hi, > when there is a single ' in a comment within a subshell, I get this > error: foo[6]: no closing quote > > Here is an example script to reproduce the problem: > > foo=$( > # It's bar: > echo bar > ) > echo $foo This is certainly not the best way to do this

Re: [sh] Single quote in comment within subshell buggy

2019-12-14 Thread Claus Assmann
On Sat, Dec 14, 2019, Richard Ulmer wrote: > foo=$( > # It's bar: > echo bar > ) > echo $foo Because I was curious I just tested it on a FreeBSD 11.2 box: no error with /bin/sh and /bin/ksh. -- Address is valid for this mailing list only.

[sh] Single quote in comment withing subshell buggy

2019-12-14 Thread Richard Ulmer
Hi, when there is a single ' in a comment within a subshell, I get this error: foo[6]: no closing quote Here is an example script to reproduce the problem: foo=$( # It's bar: echo bar ) echo $foo I found this behaviour unexpected und suspect it's a bug. I had encountered this as