Re: blowfish.c source discrepancy from reference implementation

2011-04-25 Thread Paul DeBruicker
On 04/25/2011 05:15 PM, Andreas Gunnarsson wrote: The problem described in [3] is due to key being stored as char, which may be signed. The code in [1] uses u_int8_t which is unsigned and therefore not sign extended. So [1] does not have this problem. /usr/src/sys/crypto/blf.c is also OK. An

blowfish.c source discrepancy from reference implementation

2011-04-25 Thread Paul DeBruicker
Hi - I used the OpenBSD implementation of Blowfish and Bcrypt as a reference for a Smalltalk port I made. While making the port I noticed that on line 409 of blowfish.c [1] the OpenBSD version may differ from the recommendation of the reference version posted at Bruce Schneier's website [2].