Re: Little update to authpf

2009-09-06 Thread Rafal Bisingier
Hi, About a year ago I've sent a simple patch for authpf, which adds some nice (as I think) feature to authpf. My patch was reviewed and extended (and corrected) by couple of people, but since then did not get into cvs. So now is my second try. I'd really like to get this kind of functionality in

Re: Little update to authpf

2009-09-06 Thread frantisek holop
hmm, on Sun, Sep 06, 2009 at 11:15:36PM +0200, Rafal Bisingier said that + struct stat sb; + char *path_message; printf(\r\nHello %s. , luser); printf(You are authenticated from host \%s\\r\n, ipsrc); setproctitle(%...@%s,

Little update to authpf

2008-09-11 Thread Rafal Bisingier
Hi all, I do not know if this is the correct list, or even method to send patches, but did not found anything appropriate on the OpenBSD website. I'd like to propose a little feature enhancement for the authpf. Here are the details: - authpf can show a message to an user successfully logged in -

Re: Little update to authpf

2008-09-11 Thread Ross Cameron
On Thu, Sep 11, 2008 at 2:09 PM, Rafal Bisingier [EMAIL PROTECTED]wrote: Below is a patch which change current behavior, so that the message is searched first in the /etc/authpf/USER dir, and if it's not found Would/etc/authpf/authpf.USER.messagenot be better? Sample change

Re: Little update to authpf

2008-09-11 Thread Rafal Bisingier
Hi, On Thu, 11 Sep 2008 14:26:42 +0200 Ross Cameron [EMAIL PROTECTED] wrote: On Thu, Sep 11, 2008 at 2:09 PM, Rafal Bisingier [EMAIL PROTECTED]wrote: Below is a patch which change current behavior, so that the message is searched first in the /etc/authpf/USER dir, and if it's not found

Re: Little update to authpf

2008-09-11 Thread Todd T. Fries
I think you might want to check to see if the file exists not just if the asprintf succeeds.. But yes I do agree this is useful functionality that I've tested quite thoroughly... Index: authpf.c === RCS file:

Re: Little update to authpf

2008-09-11 Thread Hannah Schroeter
Hi! On Thu, Sep 11, 2008 at 07:52:14AM -0500, Todd T. Fries wrote: I think you might want to check to see if the file exists not just if the asprintf succeeds.. But yes I do agree this is useful functionality that I've tested quite thoroughly... Another nit in the patch: Index: authpf.c

Re: Little update to authpf

2008-09-11 Thread Henning Brauer
* Hannah Schroeter [EMAIL PROTECTED] [2008-09-11 15:20]: Hi! On Thu, Sep 11, 2008 at 07:52:14AM -0500, Todd T. Fries wrote: I think you might want to check to see if the file exists not just if the asprintf succeeds.. But yes I do agree this is useful functionality that I've tested quite

Re: Little update to authpf

2008-09-11 Thread Hannah Schroeter
Hi! On Thu, Sep 11, 2008 at 03:28:07PM +0200, Henning Brauer wrote: * Hannah Schroeter [EMAIL PROTECTED] [2008-09-11 15:20]: On Thu, Sep 11, 2008 at 07:52:14AM -0500, Todd T. Fries wrote: I think you might want to check to see if the file exists not just if the asprintf succeeds.. But yes I

Re: Little update to authpf

2008-09-11 Thread Henning Brauer
* Hannah Schroeter [EMAIL PROTECTED] [2008-09-11 15:56]: How about checking whether it's a regular file, too? to preven symlinks? nah... stat follows symlinks, so that's no problem. However it'll prevent directories, pipes, sockets and devices. d'oh. of course. ignore me. -- Henning

Re: Little update to authpf

2008-09-11 Thread Rafal Bisingier
Hi, On Thu, 11 Sep 2008 07:52:14 -0500 Todd T. Fries [EMAIL PROTECTED] wrote: I think you might want to check to see if the file exists not just if the asprintf succeeds.. Yes, that's a really good idea... ;-) But yes I do agree this is useful functionality that I've tested quite