Re: Probable off by one in src/usr.bin/rdist/docmd.c

2020-01-03 Thread Aham Brahmasmi
> Sent: Thursday, January 02, 2020 at 8:21 PM > From: "Otto Moerbeek" > To: "Aham Brahmasmi" > Cc: misc@openbsd.org > Subject: Re: Probable off by one in src/usr.bin/rdist/docmd.c > > On Thu, Jan 02, 2020 at 07:45:25PM +0100, Aham Brahmasmi wrote: > &g

Re: Probable off by one in src/usr.bin/rdist/docmd.c

2020-01-02 Thread Otto Moerbeek
On Thu, Jan 02, 2020 at 07:45:25PM +0100, Aham Brahmasmi wrote: > > Sent: Thursday, January 02, 2020 at 4:26 PM > > From: "Otto Moerbeek" > > To: "Aham Brahmasmi" > > Cc: misc@openbsd.org > > Subject: Re: Probable off by one in src/usr.bin/r

Re: Probable off by one in src/usr.bin/rdist/docmd.c

2020-01-02 Thread Aham Brahmasmi
> Sent: Thursday, January 02, 2020 at 4:26 PM > From: "Otto Moerbeek" > To: "Aham Brahmasmi" > Cc: misc@openbsd.org > Subject: Re: Probable off by one in src/usr.bin/rdist/docmd.c > > On Thu, Jan 02, 2020 at 03:39:53PM +0100, Aham Brahmasmi wrote: > &

Re: Probable off by one in src/usr.bin/rdist/docmd.c

2020-01-02 Thread Otto Moerbeek
On Thu, Jan 02, 2020 at 03:39:53PM +0100, Aham Brahmasmi wrote: > Hallo Otto, > > Dank je Otto for your helpful reply. > > > Sent: Wednesday, January 01, 2020 at 3:36 PM > > From: "Otto Moerbeek" > > To: "Aham Brahmasmi" > > Cc: misc

Re: Probable off by one in src/usr.bin/rdist/docmd.c

2020-01-02 Thread Aham Brahmasmi
Hallo Otto, Dank je Otto for your helpful reply. > Sent: Wednesday, January 01, 2020 at 3:36 PM > From: "Otto Moerbeek" > To: "Aham Brahmasmi" > Cc: misc@openbsd.org > Subject: Re: Probable off by one in src/usr.bin/rdist/docmd.c > > On Wed, Jan 01,

Re: Probable off by one in src/usr.bin/rdist/docmd.c

2020-01-01 Thread Otto Moerbeek
On Wed, Jan 01, 2020 at 04:02:24PM +0100, Aham Brahmasmi wrote: > Namaste misc, > > Question: > In the makeconn function in src/usr.bin/rdist/docmd.c, should the 5 in > the following line be replaced by 4? > ... > static int > makeconn(char *rhost) > { > ... > (void) snprintf(buf, sizeof(buf), "%

Probable off by one in src/usr.bin/rdist/docmd.c

2020-01-01 Thread Aham Brahmasmi
Namaste misc, Question: In the makeconn function in src/usr.bin/rdist/docmd.c, should the 5 in the following line be replaced by 4? ... static int makeconn(char *rhost) { ... (void) snprintf(buf, sizeof(buf), "%.*s -S", (int)(sizeof(buf)-5), path_rdistd); ... Explanation: