Re: Value of eax register after BIOS interrupt call from boot(8)

2019-11-09 Thread Philip Guenther
On Friday, November 8, 2019, Theo de Raadt wrote: > Philip Guenther wrote: > > > No, it should be the other way, moving the “clear NT flag” block down > after > > the “save registers into save area” block > > Ah. > > Index: arch/amd64/stand/libsa/gidt.S >

Re: Value of eax register after BIOS interrupt call from boot(8)

2019-11-09 Thread Julius Zint
> > Index: arch/amd64/stand/libsa/gidt.S > === > RCS file: /cvs/src/sys/arch/amd64/stand/libsa/gidt.S,v > retrieving revision 1.11 > diff -u -p -u -r1.11 gidt.S > --- arch/amd64/stand/libsa/gidt.S 27 Oct 2012 15:43:42 -

Re: Value of eax register after BIOS interrupt call from boot(8)

2019-11-08 Thread Theo de Raadt
Philip Guenther wrote: > No, it should be the other way, moving the “clear NT flag” block down after > the “save registers into save area” block Ah. Index: arch/amd64/stand/libsa/gidt.S === RCS file:

Re: Value of eax register after BIOS interrupt call from boot(8)

2019-11-08 Thread Philip Guenther
On Friday, November 8, 2019, Theo de Raadt wrote: > Philip Guenther wrote: > > > Since we're unlikely to do _more_ with BIOS calls in the boot loader, my > > inclination would be to eliminate the structure value and the code that > > sets it (incorrectly). Opinions? > > I dunno, my crystal

Re: Value of eax register after BIOS interrupt call from boot(8)

2019-11-08 Thread Theo de Raadt
Philip Guenther wrote: > Since we're unlikely to do _more_ with BIOS calls in the boot loader, my > inclination would be to eliminate the structure value and the code that > sets it (incorrectly). Opinions? I dunno, my crystal ball provides a more cynical outlook. How about we just repair by

Re: Value of eax register after BIOS interrupt call from boot(8)

2019-11-07 Thread Philip Guenther
On Thu, Nov 7, 2019 at 9:31 AM Julius Zint wrote: > the following code snipped is from sys/arch/amd64/stand/libsa/gidt.S > > /* pass BIOS return values back to caller */ > movl%eax, 0xb*4(%esp) > movl%ecx, 0xa*4(%esp) > movl%edx, 0x9*4(%esp) > movb%bh , 0xe*4(%esp) > > /* clear

Value of eax register after BIOS interrupt call from boot(8)

2019-11-07 Thread Julius Zint
Hi misc, the following code snipped is from sys/arch/amd64/stand/libsa/gidt.S /* pass BIOS return values back to caller */ movl%eax, 0xb*4(%esp) movl%ecx, 0xa*4(%esp) movl%edx, 0x9*4(%esp) movb%bh , 0xe*4(%esp) /* clear NT flag in eflags */ /* Martin Fredriksson */ pushf pop