Re: [LOG] Warning table

Hi, it seems that Joerg's fix was missing a closing parenthesis. The following should work: if ((fp = fopen(config, "r")) == NULL) { log_warn("warn: table \"%s\"", config); return 0; } Cheers, Michael On 11 January 2016 at 14:28, Alexis VACHETTE wrote:

Re: [LOG] Warning table

Joerg, Thanks for your advice. I introduced a "goto label" because if I add a log_warn() function before the return, smtpd start and exit right away. Your fix produce a segmentation fault with the portable version. Either way I don't know why a debugging function exit/crash the daemon.

Re: [LOG] Warning table

Hi Michael, I fixed the parenthesis typo, segmentation fault nonetheless. Regards, *Alexis VACHETTE | Network and System Engineer * Sisteer France: 43 rue Pierre Valette, 92240 Malakoff – France Direct line: +33 1 70 95 51 19 | Fax: +33 1 70 95 50 90 www.sisteer.com On

Re: [LOG] Warning table

It's working with small change : *** a/table_static.c2016-01-11 14:23:24.595515300 +0100 --- b/table_static.c2016-01-11 14:25:26.991220345 +0100 *** *** 93,104 char*valp; size_t ret = 0; ! fp = fopen(config, "r"); ! ! if (fp ==

Re: [LOG] Warning table

On Mon, Jan 11, 2016 at 10:25:47AM +0100, Alexis VACHETTE wrote: > Hi, > > It was stated last week that OpenSMTPD daemon doesn't throw any warning if a > specific table isn't readable by OpenSMTPD user. > > I made a patch for the portable version on github : > > *** a/table_static.c

Re: [LOG] Warning table

Joerg, I'm ok with your comments except for the first one: it's ok to generate diffs against portable, not everyone runs OpenBSD, we simply have to adapt the diff to CVS ourselves in that case. Gilles 2016-01-11 12:52 GMT+01:00 Joerg Jung : > On Mon, Jan 11, 2016 at 10:25:47AM

Re: [LOG] Warning table

My bad, it was me too. I will do the merge request then. Regards, Alexis VACHETTE. On 11/01/2016 14:40, Alexis VACHETTE wrote: Hi Michael, I fixed the parenthesis typo, segmentation fault nonetheless. Regards, On 11/01/2016 14:38, Michael Morak wrote: Hi, it seems that Joerg's fix was