Re: boot failure after patch build cycle

2023-01-21 Thread Avon Robertson
On Sat, Jan 21, 2023 at 07:59:46AM -0300, Crystal Kolipe wrote:
> On Sat, Jan 21, 2023 at 11:26:55PM +1300, Avon Robertson wrote:
> > During the reboot, immediately after the boot> prompt disappeared the
> > machine froze.
> 
> Thanks for testing.
> 
> I've only seen this issue happen on machines which are using the amdgpu
> framebuffer driver.
> 
> I'll try to do some tests using amdgpu over the weekend, (I mostly
> developed these console patches on machines that using inteldrm).

-- 
aer

Thank you for your response Crystal.

The applied patch was the only one related to your wscons related
series of patches that I had applied. It was applied once only, before
my first kernel rebuild.

Before my second rebuild, I unmounted my /usr/obj partition and
created a new ffs file system on it.

The only Intel based hardware I have to test the patch on is an older
Dell M6600 laptop. Later today (is Sunday here,) I will update the OS,
packages, and CVS repository on it, then update /usr/src and apply
the same patch.

If it will be of help to you, I will test any future related patches. 



Re: boot failure after patch build cycle

2023-01-21 Thread Crystal Kolipe
On Sat, Jan 21, 2023 at 11:26:55PM +1300, Avon Robertson wrote:
> During the reboot, immediately after the boot> prompt disappeared the
> machine froze.

Thanks for testing.

I've only seen this issue happen on machines which are using the amdgpu
framebuffer driver.

I'll try to do some tests using amdgpu over the weekend, (I mostly
developed these console patches on machines that using inteldrm).



boot failure after patch build cycle

2023-01-21 Thread Avon Robertson
Hello misc@,

After successfully applying this patch from Crystal Kolipe;

Date: Wed, 18 Jan 2023 21:00:29 -0300
From: Crystal Kolipe 
To: t...@openbsd.org
Subject: Re: [patch] italic text on the console!
Message-ID: 
Mail-Followup-To: t...@openbsd.org
References: 
[1]

then

successfully recompiling a amd64 GENERIC.MP kernel using this snapshot

kern.version=OpenBSD 7.2-current (GENERIC.MP) #964: Wed Jan 18 14:44:37\
MST 2023

then

rebooting the machine after capturing the final output from the tmux
pane in which the patched kernel was built. The last 11 lines are
displayed below.
[2]

During the reboot, immediately after the boot> prompt disappeared the
machine froze. On the black background of the console display, in a
smaller than usual font for the 1920x1080 display, was this hex value:

0x1001000


The machine was powered off, and rebooted using /obsd.

A recursive grep search of /usr/include and /usr/src failed to hit
anything (I found) relevant to the above hex value, which I thought may
have been an address of interest.

Re-reading biosboot(8) and boot(8) offered me no clue unfortunately and
as yet, I have not thoroughly searched the source files to find the
code being used at the time. If someone could supply the name of the
relevant source file or files that may be helpful.

Similar events would likely have occurred in the past. For a known
reason or reasons?

I would be very grateful for any cluesticks as to how to find and fix
the cause of the freeze outlined above.

Please note that I have performed the above twice, using different
snapshots and the results were the same. The dmesg from the second
build snapshot is shown last.
[3]

Thank you for reading.

[1]
The diff was applied with this command line:
patch -b -d /usr/src/sys -i $HOME/diffs/kolipe-1 -V t 2>&1 | tee -a $LOGFILE

...
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--
|Index: dev/rasops/rasops.c
|===
|RCS file: /cvs/src/sys/dev/rasops/rasops.c,v
|retrieving revision 1.69
|diff -u -p -r1.69 rasops.c
|--- dev/rasops/rasops.c18 Jan 2023 11:08:49 -  1.69
|+++ dev/rasops/rasops.c18 Jan 2023 23:55:25 -
--
Patching file dev/rasops/rasops.c using Plan A...
Hunk #1 succeeded at 561.
Hunk #2 succeeded at 585.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--
|Index: dev/rasops/rasops32.c
|===
|RCS file: /cvs/src/sys/dev/rasops/rasops32.c,v
|retrieving revision 1.13
|diff -u -p -r1.13 rasops32.c
|--- dev/rasops/rasops32.c  18 Jan 2023 11:08:49 -  1.13
|+++ dev/rasops/rasops32.c  18 Jan 2023 23:55:25 -
--
Patching file dev/rasops/rasops32.c using Plan A...
Hunk #1 succeeded at 107.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--
|Index: dev/wscons/wsconsio.h
|===
|RCS file: /cvs/src/sys/dev/wscons/wsconsio.h,v
|retrieving revision 1.98
|diff -u -p -r1.98 wsconsio.h
|--- dev/wscons/wsconsio.h  15 Jul 2022 17:57:27 -  1.98
|+++ dev/wscons/wsconsio.h  18 Jan 2023 23:55:27 -
--
Patching file dev/wscons/wsconsio.h using Plan A...
Hunk #1 succeeded at 536.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--
|Index: dev/wscons/wsdisplayvar.h
|===
|RCS file: /cvs/src/sys/dev/wscons/wsdisplayvar.h,v
|retrieving revision 1.38
|diff -u -p -r1.38 wsdisplayvar.h
|--- dev/wscons/wsdisplayvar.h  13 Sep 2020 10:05:46 -  1.38
|+++ dev/wscons/wsdisplayvar.h  18 Jan 2023 23:55:27 -
--
Patching file dev/wscons/wsdisplayvar.h using Plan A...
Hunk #1 succeeded at 99.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--
|Index: dev/wscons/wsemul_vt100_subr.c
|===
|RCS file: /cvs/src/sys/dev/wscons/wsemul_vt100_subr.c,v
|retrieving revision 1.29
|diff -u -p -r1.29 wsemul_vt100_subr.c
|--- dev/wscons/wsemul_vt100_subr.c 12 Jan 2023 20:39:37 -  1.29
|+++ dev/wscons/wsemul_vt100_subr.c 18 Jan 2023 23:55:27 -
--
Patching file dev/wscons/wsemul_vt100_subr.c using Plan A...
Hunk #1 succeeded at 588.
Hunk #2 succeeded at 602.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--
|Index: dev/wsfont/wsfont.c
|===
|RCS file: /cvs/src/sys/dev/wsfont/wsfont.c,v
|retrieving revision 1.62
|diff -u -p