Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread Max Linke
On 06/05/2015 09:55 AM, Daniel Schürmann wrote: Hi all. Good news! Thank you RJ. I just one objection to the C++11 white list. The new keyword auto. No auto is awesome. I've started a new simulation Montecarlo simulation program for my PhD and use exclusively auto to declare my

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread Daniel Schürmann
Hi all. Good news! Thank you RJ. I just one objection to the C++11 white list. The new keyword auto. IMHO auto helps to speed up the code writing. But it makes the code harder to understand. Some IDEs are starting to display the real type, but that does not help in GitHub reviews or other

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread Daniel Schürmann
Hi Max, Thank you for the nice blog. I did not know all these reason pro auto. I am currently working in a huge c# project, which uses a Mixed style var / explicit types. Since It is not all my code, It is sometimes a pain to understand the code with all the vars and the mixed style:

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread RJ Ryan
On Fri, Jun 5, 2015 at 4:38 AM, Max Linke max_li...@gmx.de wrote: On 06/05/2015 09:55 AM, Daniel Schürmann wrote: Hi all. Good news! Thank you RJ. I just one objection to the C++11 white list. The new keyword auto. No auto is awesome. I've started a new simulation Montecarlo

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread RJ Ryan
On Fri, Jun 5, 2015 at 1:35 AM, Sean M. Pappalardo - D.J. Pegasus spappala...@mixxx.org wrote: On 06/04/2015 09:43 PM, RJ Ryan wrote: * Visual Studio 2013 (12.0) Does VS2015 offer more C++11 features? Since it's free, we can just declare that to be the minimum version from here on.

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread Owen Williams
On Fri, 2015-06-05 at 08:14 -0400, RJ Ryan wrote: Which can pretty much be summarized as use auto to prevent repeating yourself. My rule of thumb is, use auto when the type is long AND easily understandable from the context. So don't use auto instead of QString just because, but do use

Re: [Mixxx-devel] -std=c++11 vs -std=c++0x

2015-06-05 Thread Daniel Schürmann
++11`, so we might want to address this. Cheers, Nico https://launchpadlibrarian.net/208320762/buildlog_ubuntu-precise-amd64.mixxx_2.1~20150605-precise1_BUILDING.txt.gz https://launchpadlibrarian.net/208320762/buildlog_ubuntu-precise-amd64.mixxx_2.1%7E20150605

Re: [Mixxx-devel] can't edit wiki

2015-06-05 Thread RJ Ryan
I just created a new account and edited a page successfully. I took a look at your user account and everything looked normal too. Not really sure what's going on. I can delete the account if you'd like to try re-creating it. On Fri, Jun 5, 2015 at 12:57 PM, Be b...@gmx.com wrote: I'm still

Re: [Mixxx-devel] -std=c++11 vs -std=c++0x

2015-06-05 Thread Nico Schlömer
, Mixxx unconditionally adds `-std=c++11`, so we might want to address this. Cheers, Nico https://launchpadlibrarian.net/208320762/buildlog_ubuntu-precise-amd64.mixxx_2.1~20150605-precise1_BUILDING.txt.gz

Re: [Mixxx-devel] -std=c++11 vs -std=c++0x

2015-06-05 Thread RJ Ryan
/buildlog_ubuntu-precise-amd64.mixxx_2.1~20150605-precise1_BUILDING.txt.gz -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list

Re: [Mixxx-devel] can't edit wiki

2015-06-05 Thread Be
I'm still getting this error. There are a number of edits I've been waiting to make around the wiki. On 04/06/2015 09:43 AM, Owen Williams wrote: I'll see if I can figure out what's going on On Mon, 2015-04-06 at 09:27 -0500, Be wrote: Any idea what's going on with this? Pegasus said he has

Re: [Mixxx-devel] -std=c++11 vs -std=c++0x

2015-06-05 Thread Owen Williams
this. Cheers, Nico https://launchpadlibrarian.net/208320762/buildlog_ubuntu-precise-amd64.mixxx_2.1~20150605-precise1_BUILDING.txt.gz

Re: [Mixxx-devel] can't edit wiki

2015-06-05 Thread Be
Now I can click the edit link, but I still get the same error when I try to preview or save my edit. On 06/05/2015 01:32 PM, S.Brandt wrote: The permissions for your user are fine, you should be able to edit. Did reset your user, and you should have received a new password. If you still

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread Daniel Schürmann
Hi I have updated http://mixxx.org/wiki/doku.php/coding_guidelines?#auto according to our discussion. It is still a draft. Lets tweak it until we have a commitment. I am unsure what is the recommended version for our own typedefs: CSAMPLE sample = 0.0; auto sample = (CSAMPLE)0.0; auto sample =

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread Owen Williams
On Fri, 2015-06-05 at 22:30 +0200, Daniel Schürmann wrote: CSAMPLE sample = 0.0; This one. auto should really only be used when assigning from a function whose return value is obvious. --

Re: [Mixxx-devel] can't edit wiki

2015-06-05 Thread Sean M. Pappalardo - D.J. Pegasus
On 06/05/2015 01:19 PM, Be wrote: Now I can click the edit link, but I still get the same error when I try to preview or save my edit. Do you have any sort of script blocker running? Tests good for me with Firefox on Linux. Sincerely, Sean M. Pappalardo D.J. Pegasus Mixxx Developer -

Re: [Mixxx-devel] release progress

2015-06-05 Thread Owen Williams
I've posted a PR for some new LateNight display options. I'm definitely running up against the limits of the skinning engine so I can't do a lot more than this. But it makes it possible to specifically select the big waveforms if you want them. It also makes it possible to turn off the EQs to

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread Gavin Swanson
CSAMPLE sample(0.0); On Fri, Jun 5, 2015, 4:45 PM Owen Williams owilli...@mixxx.org wrote: On Fri, 2015-06-05 at 22:30 +0200, Daniel Schürmann wrote: CSAMPLE sample = 0.0; This one. auto should really only be used when assigning from a function whose return value is obvious.

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread Gavin Swanson
In a project the size of mixxx (at least as they come up) every situation should be enumerated and documented (to the extent possible in an os project). This provides new developers the information to maintain consistency. The code, especially in a large project that hasn't had the formatting

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread Gavin Swanson
are we in violent agreement then? Why not do the optimal thing in the first place for consistency sake? Rather than rely on the compiler to do it for you. Especially in a case like this where the optimization is no more work nor is it less readable. On Fri, Jun 5, 2015, 7:38 PM Owen Williams

Re: [Mixxx-devel] can't edit wiki

2015-06-05 Thread Be
I use AdBlock Plus. I tried disabling it but that did not change anything. On 06/05/2015 05:56 PM, Sean M. Pappalardo - D.J. Pegasus wrote: On 06/05/2015 01:19 PM, Be wrote: Now I can click the edit link, but I still get the same error when I try to preview or save my edit. Do you have any

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread Gavin Swanson
http://stackoverflow.com/a/4470763 On Fri, Jun 5, 2015, 7:21 PM Owen Williams owilli...@mixxx.org wrote: Since CSAMPLE is a simple type, assignment is best -- and when it works, assignment is the way to go (hurray for smart compilers eliding copies). With the form sample(0.0), it gives the

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread Owen Williams
That's what I said? The compiler is free to elide (remove) the temporary+copying whenever it can, but copy constructor must still be accessible On Fri, 2015-06-05 at 23:34 +, Gavin Swanson wrote: http://stackoverflow.com/a/4470763 On Fri, Jun 5, 2015, 7:21 PM Owen Williams

Re: [Mixxx-devel] c++11 support is here

2015-06-05 Thread Owen Williams
Since CSAMPLE is a simple type, assignment is best -- and when it works, assignment is the way to go (hurray for smart compilers eliding copies). With the form sample(0.0), it gives the impression that CSAMPLE is a complex type with a constructor. On Fri, 2015-06-05 at 22:16 +, Gavin Swanson