On 09/22/2015 06:56 AM, Be wrote:
Wouldn't that require making Node.js a dependency for the tests? Is that
worth it?
For testing? I would say so, since it would only be required for running
the tests, not just building Mixxx. Though I have no idea how heavy
Node.js is.
Sincerely,
Sean M.
Hello,
I noticed that there is plenty of Javascript code in Mixxx repo and it
Quality left much to desire. Most of them are in good shape but still
there is Ecmascript violations most of them. Should it at leas get
through the jshint (https://en.wikipedia.org/wiki/JSHint) and same
coding style
Hello.
This is a good point. Can you possibly add a test to the suite that runs
jshint (and other checkers in the future) on all of the mapping files?
Sincerely,
Sean M. Pappalardo
"D.J. Pegasus"
Mixxx Developer - Controller Specialist
smime.p7s
Description: S/MIME Cryptographic Signature
Wouldn't that require making Node.js a dependency for the tests? Is that
worth it?
On 09/22/2015 08:50 AM, Sean M. Pappalardo - D.J. Pegasus wrote:
> Hello.
>
> This is a good point. Can you possibly add a test to the suite that runs
> jshint (and other checkers in the future) on all of the
I'm already using "jshint --show-non-errors" before publishing a new version
of a mapping script.
My mapping script contains a special header with some inline directives for
JSHint:
// JSHint configuration
