Re: [Mixxx-devel] Fwd: Re: formating source Code with clang-format

2015-06-11 Thread Tuukka Pasanen
Hello, I'm with auto formatting people. Before we had code auto formatting it was mostly complaining coding style. Now like RJ said nobody can argue because there is one to rule them all system. I also like to see cppcheck and flawfinder style hooks to check code for dummy mistakes. Never

Re: [Mixxx-devel] Fwd: Re: formating source Code with clang-format

2015-06-09 Thread RJ Ryan
On Tue, Jun 9, 2015 at 4:37 PM, Daniel Schürmann dasch...@mixxx.org wrote: Hi I have very bad experience in a similar size closed source project. The code was cluttered and the source control blame feature broken When a line is auto-formatted you can just blame from that revision to find

[Mixxx-devel] Fwd: Re: formating source Code with clang-format

2015-06-09 Thread Daniel Schürmann
Hi I have very bad experience in a similar size closed source project. The code was cluttered and the source control blame feature broken We finally revert all the auto formated stuff. IMHO a code style checker will help to get around the noise in the PRs. We can also provide an auto-formater

Re: [Mixxx-devel] Fwd: Re: formating source Code with clang-format

2015-06-09 Thread RJ Ryan
On Tue, Jun 9, 2015 at 4:43 PM, RJ Ryan rr...@mixxx.org wrote: I can remember that RJs biggest issue in the clang autotransformer was the alignment with the open parenthesis. If we set it just to double indent most issues should be solved (sove-able) FWIW this was Emacs code formatting, not