Re: [Mixxx-devel] PATCH: fix playpos rounding in EngineBuffer

2010-09-14 Thread Albert Santoni
I haven't reviewed this patch, but I did give it a quick test tonight. The waveform only went half-speed and I couldn't seek backwards anymore, so maybe the code needs another look at. Thanks, Albert On Sat, Sep 11, 2010 at 1:43 PM, mad jester wrote: > Well... I have a new patch. I factored the

Re: [Mixxx-devel] PATCH: fix playpos rounding in EngineBuffer

2010-09-11 Thread mad jester
Well... I have a new patch. I factored the sum to new_playpos into the loop but I base it off rate_add, not buffer_size since buffer_size is just the integer aproximation. mixxx-fix-playpos.patch Description: Binary data

Re: [Mixxx-devel] PATCH: fix playpos rounding in EngineBuffer

2010-09-11 Thread Albert Santoni
Forgot to copy the list... On Sat, Sep 11, 2010 at 1:31 PM, Albert Santoni wrote: > The EngineBuffer changes look OK to me, I think I understand what you did. > > This stuff in EBSL looks wrong to me though: > > === modified file 'mixxx/src/engine/enginebufferscalelinear.cpp' > --- old/mixxx/src/

Re: [Mixxx-devel] PATCH: fix playpos rounding in EngineBuffer

2010-09-09 Thread mad jester
BTW, this playpos patch is for fixing the way EBSSL sounds when doing scratching via Vinyl Control. It shows no change for EBSSL under normal circumstances. -- Automate Storage Tiering Simply Optimize IT performance and ef

Re: [Mixxx-devel] PATCH: fix playpos rounding in EngineBuffer

2010-08-28 Thread mad jester
On Tue, Aug 24, 2010 at 8:56 PM, mad jester wrote: > I am submitting a patch which conserves the decimal part of > filepos_play... > Please feel free to comment and nitpick. I really want to push for > including this in 1.8 and the only way to succesfully do so is to make > sure it's entirely saf