Re: [Mixxx-devel] compile flags

2015-02-03 Thread Nico Schlömer
> Ok, should we add some of the extra Debian flags you brought up to our Scons > script? Not necessary. (The flags are added to the env variables which are automatically picked up by SCons.) > Unfortunately we have actually a hardware limitation. > We need a CPU that allows hardware denormals pre

Re: [Mixxx-devel] compile flags

2015-02-03 Thread Daniel Schürmann
Hi Nico, Ok, should we add some of the extra Debian flags you brought up to our Scons script? Unfortunately we have actually a hardware limitation. We need a CPU that allows hardware denormals prevention. This is true for Intel >= Pentium 4 and all ARM CPUs Fixing this with a software solution is

Re: [Mixxx-devel] compile flags

2015-02-03 Thread Nico Schlömer
So it seems that I was wrong and in Debian we are actually allowed to use our own flags, cf. the thread starting at [1]. The only limitation: Don't use flags that make assumptions about the platform. –Nico [1] https://lists.debian.org/debian-mentors/2015/02/msg00025.html On Tue, Feb 3, 2015 at

Re: [Mixxx-devel] compile flags

2015-02-02 Thread Nico Schlömer
> Remember that we already rebuild some libraries to have an > optimized build. I must say that in this particular instance I see the benefit of compiling a Mixxx-dependency with `-O3`. Then again, many packages would profit from `-O3` in a similar way. Allowing all packages to handle their own de

Re: [Mixxx-devel] compile flags

2015-02-02 Thread Daniel Schürmann
Hi Nico, now we have build=none in https://github.com/mixxxdj/mixxx/pull/436 But please do not use it for you ppa builds. Lets tweak that in an extra round. Am 02.02.2015 um 22:27 schrieb Daniel Schürmann: > Hi Nico, > > our equivalent to CMAKE_BUILD_TYPE is > build=debug > and > build=release

Re: [Mixxx-devel] compile flags

2015-02-02 Thread Daniel Schürmann
Hi Nico, our equivalent to CMAKE_BUILD_TYPE is build=debug and build=release both adds -pipe -Wall -Wextra -g CMake supports these builds by default: None Debug Release RelWithDebInfo and MinSizeRel We may add a build=none option to use no compiler flags. But I am still in the opinion that we

Re: [Mixxx-devel] compile flags

2015-02-02 Thread Nico Schlömer
> how does Debian set these flags. Via the environment variables (CFLAGS & friends). They are then picked up by the build system, e.g., SCons. > What is the issue with [...] There's nothing wrong with any of these options as long as there is there is a way to turn them off. If you're building pr

Re: [Mixxx-devel] compile flags

2015-02-02 Thread Daniel Schürmann
Hi Nico, how does Debian set these flags. Is there a building script with some arguments, resulting in in this options? This commit switches from CXX to CC flags https://github.com/daschuer/mixxx/commit/7d3fe7d9df55d5805e514f82b6968e168903936a So it should work. After merging https://github.com/m

Re: [Mixxx-devel] compile flags

2015-02-02 Thread Nico Schlömer
Debian sets ``` -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 ``` and Mixxx nonchalantly adds ``` -pipe -Wall -Wextra -g -pthread -O3 -ffast-math -funroll-loops -fomit-frame-pointer ``` It'd be arguably cleaner if Mixxx had a option that do

Re: [Mixxx-devel] compile flags

2015-02-01 Thread Daniel Schürmann
IMHO there is currently no way to bypass the Scons build flags. We may introduce such a way, but what is the use case to provide build flags from a Linux distributor? Even in a autotools project, they are set inside the build scrips maintained by the project. However I be aware that there is a com

Re: [Mixxx-devel] compile flags

2015-02-01 Thread Nico Schlömer
> Do you have special requirements. Well, I don't want SCons to interfere with the build flags I (/Debian) provide. What are the SCons flags I'll have to set? Cheers, Nico On Sun, Feb 1, 2015 at 9:06 PM, Daniel Schürmann wrote: > Hi Nico, > > the build flags are generated from the various s

Re: [Mixxx-devel] compile flags

2015-02-01 Thread Daniel Schürmann
Hi Nico, the build flags are generated from the various scons flags controlled by build/features.py and build/depends.py Please note that there is a pending pull request, that cleans up the flags a bit. https://github.com/mixxxdj/mixxx/pull/436 Do you have special requirements. Kind regards, D