Re: [Mixxx-devel] every build broken

2016-01-29 Thread RJ Ryan
Ah, welp: https://gitorious.org/qt/qt?p=qt:qt.git;a=blob;f=src/corelib/global/qglobal.h;h=96fbeee0aeb5a6c89dc8cc3ffa4626c922834e09;hb=343df131f7207d65932c6505769aa2fb7fc04713#l428 Qt 4 isn't being developed anymore so they're not updating stuff like this. Compare to Qt 5: https://gitorious.org/qt

Re: [Mixxx-devel] every build broken

2016-01-29 Thread RJ Ryan
There's a list of "blessed" C++11 features here: http://mixxx.org/wiki/doku.php/coding_guidelines#c_11 Unit tests verifying the presence of the features wouldn't necessarily help since it's the code reviewer's job to check that list and the MSVC compatibility page say we support it: https://msdn.m

Re: [Mixxx-devel] every build broken

2016-01-29 Thread Owen Williams
(emails with a link to the console output, particularly) On Fri, 2016-01-29 at 12:53 -0500, Owen Williams wrote: > I'm happy with the system the way it is. The only flaw is that we don't > get automatic emails when a build fails. > > On Fri, 2016-01-29 at 08:41 -0800, Sean M. Pappalardo - D.J.

Re: [Mixxx-devel] every build broken

2016-01-29 Thread Owen Williams
I'm happy with the system the way it is. The only flaw is that we don't get automatic emails when a build fails. On Fri, 2016-01-29 at 08:41 -0800, Sean M. Pappalardo - D.J. Pegasus wrote: > > On 01/29/2016 08:25 AM, Owen Williams wrote: > > The build server is the correct place for these bugs t

Re: [Mixxx-devel] every build broken

2016-01-29 Thread Sean M. Pappalardo - D.J. Pegasus
On 01/29/2016 08:25 AM, Owen Williams wrote: > The build server is the correct place for these bugs to be caught, Oh, I agree. I'm wondering if there's a way for us to have the build server run a script of some kind on all platforms that tries compiling small test programs that exercise C++09/11

Re: [Mixxx-devel] every build broken

2016-01-29 Thread Owen Williams
The build server is the correct place for these bugs to be caught, the only problem is that the build server sucks. In this case, this is a c++11 feature that is not supported by MSVC -- adding a test on ubuntu wouldn't catch it. On Fri, 2016-01-29 at 08:21 -0800, Sean M. Pappalardo - D.J. Pegasu

Re: [Mixxx-devel] every build broken

2016-01-29 Thread Sean M. Pappalardo - D.J. Pegasus
On 01/29/2016 06:31 AM, Owen Williams wrote: > Boo C++11 support on anything except linux. I'll fix these. Perhaps we should add tests for C++09, 11 and 13 support so we don't have to find out by trial-and-error if/when they're supported on our build servers. Sincerely, Sean M. Pappalardo