[Mixxx-devel] travis-ci restart

2015-06-10 Thread Sébastien BLAISOT
Hi, I have a failed (stalled) build in travis-ci on PR606 (last commit). I suspect a temporary problem on travis-ci. Is there a way to restart travis-ci compilation other than pushing a new commit ? Thanks, -- Sébastien Blaisot --

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread Max Linke
On 06/10/2015 08:20 AM, Daniel Schürmann wrote: > I think we have two external limits for code length, the historical 80 > columns and the 115 columns in GitHub pull requests. > Our 80 columns is already "not a strict requirement", changing it to a > strict requirement and auto-reformat it, clutt

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread Daniel Schürmann
@Max: Are the current line length in Mixxx working for you? If yes, we can continue with the 80 as a "not a strict requirement". We may use 80 as a setting while editing (Ctrl-Shift-F), but not break lines during a mass auto-format. 2015-06-10 9:44 GMT+02:00 Max Linke : > > > On 06/10/2015 08:20

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread Max Linke
On 06/10/2015 10:05 AM, Daniel Schürmann wrote: > @Max: Are the current line length in Mixxx working for you? I haven't noticed anything with the current line lengths. In the end it doesn't matter much for me which line-length we choose. I just wanted to mention that 80 seems to be a value that

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread Daniel Schürmann
The idea is to use a none or a big (115) column count for the mass auto format, to get around the code cluttering. The 80 size may be part of a second clang script that is intended to be invoked manually during editing. If clang produces less readable code, the developer is still there to fix it.

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread Gavin Swanson
If clang can't do a smart auto line length like we're talking about, just disable the auto line length portion of clang. Continue to use it for parens etc. Most editors can display vertical lines at various locations. Put a line at 80 and one at 115. Use then as reference and make a judgement call

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread RJ Ryan
On Wed, Jun 10, 2015 at 9:09 AM, Gavin Swanson wrote: > If clang can't do a smart auto line length like we're talking about, just > disable the auto line length portion of clang. Continue to use it for > parens etc. > clang-format always reformats every line to match its rules. So if it sees a st

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread RJ Ryan
On Wed, Jun 10, 2015 at 5:31 AM, Daniel Schürmann wrote: > The idea is to use a none or a big (115) column count for the mass auto > format, to get around the code cluttering. > > The 80 size may be part of a second clang script that is intended to be > invoked manually during editing. > If clang

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread Owen Williams
On Wed, 2015-06-10 at 09:16 -0400, RJ Ryan wrote: > > > > The part of clang-format which frees you from having to talk about > code style is that there is only one right way to format the code. > Letting the developer have any choice in the matter goes against this. > Agree. I don't really

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread Daniel Schürmann
I think we should give ColumnLimit: 0 a try. "A column limit of 0 means that there is no column limit. In this case, clang-format will respect the input's line breaking decisions within statements unless they contradict other rules." 2015-06-10 15:28 GMT+02:00 Owen Williams : > On Wed, 2015-06

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread Max Linke
On 06/10/2015 03:31 PM, Daniel Schürmann wrote: > I think we should give ColumnLimit: 0 a try. > > "A column limit of 0 means that there is no column limit. In this case, > clang-format will respect the input's line breaking decisions within > statements unless they contradict other rules." I just

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread Daniel Schürmann
Which version of clang-format do you use? Can this be a bug like this: https://github.com/travisjeffery/ClangFormat-Xcode/issues/81 Can you give an example where ColumnLimit: 0 fails? Searching gitHub there are a lot of projects using ColumnLimit: 0 https://github.com/search?q=ColumnLimit%3A+0&ty

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread Max Linke
On 06/10/2015 04:16 PM, Daniel Schürmann wrote: > Which version of clang-format do you use? > Can this be a bug like this: > https://github.com/travisjeffery/ClangFormat-Xcode/issues/81 > > Can you give an example where ColumnLimit: 0 fails? I use clang-format-3.6 > QLayout* pLayout = NULL

[Mixxx-devel] Rane SL4 Support

2015-06-10 Thread Jamie Carranza
Hi, I'm not a developer but have much interest in using a Rane SL-4 on a Linux system. Would it help to donate one to Mixxx developers to help get it working on Linux? I have one I'd be willing to give up if so. Or is the issue with Alsa or Pulseaudio not supporting the device? -Jamie

Re: [Mixxx-devel] Rane SL4 Support

2015-06-10 Thread Sean M. Pappalardo - D.J. Pegasus
On 06/10/2015 11:03 AM, Jamie Carranza wrote: Hi, I'm not a developer but have much interest in using a Rane SL-4 on a Linux system. Would it help to donate one to Mixxx developers to help get it working on Linux? I have one I'd be willing to give up if so. Or is the issue with Alsa or Pulse

Re: [Mixxx-devel] Rane SL4 Support

2015-06-10 Thread Be
I posted on alsa-devel about this a few months ago and got no response. I emailed Mark Hills, the xwax developer, who wrote the driver quirk for the old SL1 (a USB 1.1 device; the SL2/3/4 series is USB 2.0). He responded to me initially but I never heard back from him after that. I posted on th

Re: [Mixxx-devel] formating source Code with clang-format

2015-06-10 Thread Daniel Schürmann
Hi, I have played a bit with clang-format and it turns out that we need AlwaysBreakBeforeMultilineStrings: false ColumnLimit: 0 To fix most cluttering the issues. But now we have a new one: Double indentation fails in certain palaces. Am 10.06.2015 um 17:01 schrieb Max Linke: > > > On 06/10

[Mixxx-devel] wiki overhaul

2015-06-10 Thread Be
I have started overhauling the wiki. Take a look and feel free to edit. On the front page, I: * moved the info about GSoC to its own page, * moved the links to old meeting minutes to their own page, * removed the outdated and confusing link about the Hercules driver, * updated the manual link to t