Re: [Mixxx-devel] travis MacOS build failing
The fix worked for mixxx.cpp, but the whole compilation didn't succeed due to time limit. - Ran for 47 min 4 sec - https://travis-ci.org/mixxxdj/mixxx/jobs/319868872 Although the linux compile needed just 29 minutes for build and test and there's also these notable differences: Time to git clone in linux: 11 seconds. On OSX: 92, then, around 9 minutes for updating the system on OSX, 0 on linux. Comparing this to another build from another day, it looks like the system is more saturated: https://travis-ci.org/mixxxdj/mixxx/jobs/310967688 -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] travis MacOS build failing
Ok, I've opened the pull request https://github.com/mixxxdj/mixxx/pull/1435 Changed the method signature as suggested, and fixed two other warnings, including the widgethider one. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] travis MacOS build failing
On Thu, Dec 21, Sébastien BLAISOT wrote: > can anyone fix this ? While you guys fix build errors, please decide what kind of boolean src/util/widgethider.cpp::eventFilter() should return: true, of false, or "lass Dich überraschen". Thanks. Olaf signature.asc Description: PGP signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] travis MacOS build failing
ok, that makes sense, brew installed QT 5.9.3 on the last sucessful build and it now installs qt 5.10.0 which make our build fail. So it wil be the same whatever os you use, it's juste related to qt version. Do you have fun to work on this Josep ? in the meantime, I will see if I can update our build script used by travis to specifically stay on qt 5.9.x. It's not a good think that our CI is based on a QT version we don't use to produce the final binary. regards, sb Le 21/12/2017 à 13:58, Josep Maria Antolin a écrit : I saw it and I think the cause is that Qthread now has a create () method that is conflicting with our previous create () method in SingletonInstance, of whoch Statsmanager extends. We need to modify SingletonInstance and change the create method to createInstance () , for example. I don't have Osx, so I would only be able to test this with travisci, although I am confident that this is the solution. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] travis MacOS build failing
I saw it and I think the cause is that Qthread now has a create () method that is conflicting with our previous create () method in SingletonInstance, of whoch Statsmanager extends. We need to modify SingletonInstance and change the create method to createInstance () , for example. I don't have Osx, so I would only be able to test this with travisci, although I am confident that this is the solution. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
