Re: [mkgmap-dev] problem with reading style file

2020-03-18 Thread Gerd Petermann
Hi Mike, "Previous versions are happy with this." Yes, somehow, because they ignored the error and also the rule. What's the expected effect of this rule? Gerd Von: mkgmap-dev im Auftrag von Mike Baggaley Gesendet: Mittwoch, 18. März 2020 21:54 An:

[mkgmap-dev] Commit r4471: remove dead code

2020-03-18 Thread svn commit
Version mkgmap-r4471 was committed by gerd on Thu, 19 Mar 2020 remove dead code http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap=4471 ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk

[mkgmap-dev] problem with reading style file

2020-03-18 Thread Mike Baggaley
Hi Gerd, it looks like the merge of the is-in branch has introduced a bug in the style file reader. I now get the following error: Error in style: Error: (inc/address:19): Cannot start rule with tag!=* Could not open style style The offending line is: type()=way & highway!=* {delete

Re: [mkgmap-dev] Performance with --bounds option

2020-03-18 Thread Gerd Petermann
Hi Ticker, I forgot to remove some experimental code for is-in branch in BoundaryQuadTree. Fixed with r4469. I'll probably also remove the methods pointInsideArea() and pointInsideSingularArea() in BoundaryUtil. Gerd Von: mkgmap-dev im Auftrag von

[mkgmap-dev] Commit r4470: genSea.patch by Ticker Berkin

2020-03-18 Thread svn commit
Version mkgmap-r4470 was committed by gerd on Wed, 18 Mar 2020 genSea.patch by Ticker Berkin fixes flooded areas caused by changes in r4392 and other issues with unclosed coastlines http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap=4470 ___

[mkgmap-dev] Commit r4469: fix performance issue introduced with merge from is-in branch:

2020-03-18 Thread svn commit
Version mkgmap-r4469 was committed by gerd on Wed, 18 Mar 2020 fix performance issue introduced with merge from is-in branch: Use again Area.contains() instead of BoundaryUtil.pointInsideArea() http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap=4469

Re: [mkgmap-dev] Performance with --bounds option

2020-03-18 Thread Ticker Berkin
Have done: http://files.mkgmap.org.uk/download/462/74220001.osm.pbf Ticker On Wed, 2020-03-18 at 16:26 +, Gerd Petermann wrote: > Hi Ticker, > > will look at it tomorrow. Maybe you can upload the file to > http://files.mkgmap.org.uk/ > > Gerd > >

Re: [mkgmap-dev] Performance with --bounds option

2020-03-18 Thread Gerd Petermann
Hi Ticker, will look at it tomorrow. Maybe you can upload the file to http://files.mkgmap.org.uk/ Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Mittwoch, 18. März 2020 11:56 An: Development list for mkgmap Betreff: Re: [mkgmap-dev]

Re: [mkgmap-dev] precompiled sea

2020-03-18 Thread Gerd Petermann
Hi David, yes, sounds like noise unless you did not change anything else. If you think that a newer version of mkgmap solved the problem please double check with the older mkgmap version so that you can be sure that this is the reason. Gerd Von:

Re: [mkgmap-dev] precompiled sea

2020-03-18 Thread David
Hello Ticker and Gerd, I may introduce some noise in your search. I had a problem with sea generation for Ireland and I wrote about that few weeks ago. Gerd or Ticker suggested to me to update my precompiled sea files. I did it but it did not solve the problem of flooded areas (even with OSM

Re: [mkgmap-dev] Performance with --bounds option

2020-03-18 Thread Ticker Berkin
Hi Gerd It's 74220001: 2674688,-700416 to 2811904,-233472 # : 57.392578,-15.029297 to 60.336914,-5.009766 Ticker On Wed, 2020-03-18 at 10:46 +, Gerd Petermann wrote: > Hi Ticker, > > please tell me the tile boundaries > > Gerd > > > > Von:

Re: [mkgmap-dev] Performance with --bounds option

2020-03-18 Thread Gerd Petermann
Hi Ticker, please tell me the tile boundaries Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Mittwoch, 18. März 2020 11:43 An: mkgmap development Betreff: [mkgmap-dev] Performance with --bounds option Hi Gerd With the current version I

Re: [mkgmap-dev] Processing of mp source

2020-03-18 Thread Andrzej Popowski
Hi Mike, > I think that if a copyright file is provided, this should override any > existing copyright messages from any input files It looks like current processing of copyright-file is to override any previously defined copyright. This is acceptable, only needs a clear explanation in

[mkgmap-dev] Performance with --bounds option

2020-03-18 Thread Ticker Berkin
Hi Gerd With the current version I have a tile that takes 3.5 hours to build. With an old version (r4295) it took about 3 minutes. Without --bounds it takes 1 minute 15 secs. Relevant options are: --bounds=bounds.zip --location-autofill=is_in,nearest >From the mkgmap.log files: INFO:

Re: [mkgmap-dev] precompiled sea

2020-03-18 Thread Ticker Berkin
Hi Gerd The version in my patch is simpler and works for both createLandPolygons and createSeaPolygons (both contain a subtle "+= 4") Ticker On Wed, 2020-03-18 at 10:26 +, Gerd Petermann wrote: > Hi Ticker, > > I finally understood what was wrong in the addCorners() method, so > this

Re: [mkgmap-dev] precompiled sea

2020-03-18 Thread Ticker Berkin
Hi Gerd I was just going through the code and this is what I had so far: The significant changes are in createInnerWays/createLandPolygons r4389 createInnerWays extracts land/anticlockwise/islands from the hitMap. It has some logical mistakes like a 50% chance of putting an erroneous start/end

Re: [mkgmap-dev] precompiled sea

2020-03-18 Thread Gerd Petermann
Hi Ticker, I finally understood what was wrong in the addCorners() method, so this patch shows the minimal change to make it work. Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Mittwoch, 18. März 2020 11:05 An: Development list for

Re: [mkgmap-dev] precompiled sea

2020-03-18 Thread Gerd Petermann
Hi Ticker, OK, my results: The refactoring in r4382 introduced two bugs. With the partial revert in r4391 both bugs were fixed. With r4392 one bug was re-introduced. :( I've attached a small patch for that. Now I wonder if your longer patch fixes any other issues? Gerd

Re: [mkgmap-dev] precompiled sea

2020-03-18 Thread Gerd Petermann
Hi Ticker, forget it. Found an older extract of Ireland which shows the error with r4382, but not with r4380 or with your patch. I just want to understand how the changes in 4381 changed this before committing your patch... Gerd Von: mkgmap-dev im

Re: [mkgmap-dev] precompiled sea

2020-03-18 Thread Gerd Petermann
Hi Ticker, thanks for the patch. Do you have an example file that shows how 4381 introduced new problems which are now solved? Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Dienstag, 17. März 2020 17:40 An: Development list for mkgmap