Re: [mkgmap-dev] [PATCH v2] - handle "anti-islands"

2010-01-28 Thread Marko Mäkelä
Hi Mark, > > > Can you please check to see whether this location is situated very > > > close to the corner of a tile? I am guessing that the coastline cuts > > > the corner of a tile and so you end up with nodes on each of the tile's > > > edges at the corner. > > > > Like I wrote in the message

Re: [mkgmap-dev] [PATCH v2] - handle "anti-islands"

2010-01-27 Thread Mark Burton
Hi Marko, > > Please try the attached patch and see if it gets rid of the "can't be > > merged" error you are getting when generating sea. > > Sorry, no dice. I still see several of the warnings, including the one > that I reported last night: > > 2010/01/27 23:40:12 WARNING (Osm5XmlHandler):

Re: [mkgmap-dev] [PATCH v2] - handle "anti-islands"

2010-01-27 Thread Marko Mäkelä
Hi Mark, On Tue, Jan 26, 2010 at 10:53:48PM +, Mark Burton wrote: > > Hi Marko, > > Please try the attached patch and see if it gets rid of the "can't be > merged" error you are getting when generating sea. Sorry, no dice. I still see several of the warnings, including the one that I repor

Re: [mkgmap-dev] [PATCH v2] - handle "anti-islands"

2010-01-26 Thread Mark Burton
Hi Marko, Please try the attached patch and see if it gets rid of the "can't be merged" error you are getting when generating sea. Mark diff --git a/src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java b/src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java index b90fda1..d6cacab

Re: [mkgmap-dev] [PATCH v2] - handle "anti-islands"

2010-01-26 Thread Mark Burton
Marko, > > 2010/01/26 23:26:58 WARNING (Osm5XmlHandler): Way null > > (http://www.openstreetmap.org/browse/way/4611686018427418078) has > > consecutive nodes with the same coordinates > > (http://www.openstreetmap.org/?mlat=62.22656&mlon=25.82736&zoom=17) but > > they can't be merged becaus

Re: [mkgmap-dev] [PATCH v2] - handle "anti-islands"

2010-01-26 Thread Mark Burton
Marko, > Yes, it goes away if I don't generate sea. I reran --generate-sea=polygons > without your anti-island patch: > > 2010/01/26 23:26:58 WARNING (Osm5XmlHandler): Way null > (http://www.openstreetmap.org/browse/way/4611686018427418078) has consecutive > nodes with the same coordinates

Re: [mkgmap-dev] [PATCH v2] - handle "anti-islands"

2010-01-26 Thread Marko Mäkelä
Hi Mark, > > I tested both without and with --generate-sea=polygons. Sorry, > > I did not run --generate-sea=polygons without your patch. With > > generate-sea, I found some anti-treasure like the following. > > > > 2010/01/26 22:41:52 WARNING (Osm5XmlHandler): Way null > > (http://www.opens

Re: [mkgmap-dev] [PATCH v2] - handle "anti-islands"

2010-01-26 Thread Mark Burton
Hello Marko, > I tested with the FI map, but did not get any anti-island warnings. > I tested both without and with --generate-sea=polygons. Sorry, > I did not run --generate-sea=polygons without your patch. With > generate-sea, I found some anti-treasure like the following. > > 2010/01/26 22:

Re: [mkgmap-dev] [PATCH v2] - handle "anti-islands"

2010-01-26 Thread Marko Mäkelä
Hi Mark, On Tue, Jan 26, 2010 at 05:51:07PM +, Mark Burton wrote: > > v2 - now checks to see if an anti-island is surrounded by water or land. > > If surrounded by water, it is converted back into an island (tagged > with the land tag) and a warning message is issued. > > Tested with the GB

[mkgmap-dev] [PATCH v2] - handle "anti-islands"

2010-01-26 Thread Mark Burton
v2 - now checks to see if an anti-island is surrounded by water or land. If surrounded by water, it is converted back into an island (tagged with the land tag) and a warning message is issued. Tested with the GB map, it detected a handful of anti-islands that should have been islands but their p