Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-27 Thread Dermot McNally
I love the roundabout warnings and, with their help, I've been able to fix all the broken roundabouts in Ireland that they have identified. In the process, though, I've spotted a particular kind of false positive that I suspect we can avoid. Consider this way:

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-27 Thread Mark Burton
Hi Dermot, On Tue, 27 Oct 2009 23:36:17 + Dermot McNally derm...@gmail.com wrote: I love the roundabout warnings and, with their help, I've been able to fix all the broken roundabouts in Ireland that they have identified. In the process, though, I've spotted a particular kind of false

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-27 Thread Dermot McNally
Hi Mark, 2009/10/27 Mark Burton ma...@ordern.com: misc roundabout related breakage in the GB data). So far, my solution in this situation is just to partition one of the fake flares so that it will no longer trigger a warning. Yup, mine too. Your suggestion to avoid the warning is probably

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-27 Thread Dermot McNally
2009/10/28 Mark Burton ma...@ordern.com: Unfortunately, obtaining the roundabout's diameter is rather a lot of work (for me and the computer!) as the original ways that make up the roundabout are no longer at hand. It probably could be done but I don't think it's really worth it. I shall go

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-21 Thread Toby Speight
0 In article 20091021152223.19ac5...@crow, 0 Mark Burton URL:mailto:ma...@ordern.com (Mark) wrote: Mark Hi Toby, It might be an idea to report the erroneous ways using the 'browse' URL of that way. For example: URL: http://www.openstreetmap.org/browse/way/34875101 Mark It already reports

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-05 Thread charlie
Quoting Mark Burton ma...@ordern.com: Even if you don't drive on the left (almost the whole world?) you may care to try out the roundabout checking. The FT had an article about this at the weekend. Some interesting stats: * One-third of the world's population and one-third of the world's

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-04 Thread Charlie Ferrero
Mark Burton wrote: Hi Charlie, If there's a way you can share a pre-built jar file then I'd be happy to check it out as I spent ages fixing roundabouts in the Languedoc earlier this year. I've mailed one directly to you. I must be doing something wrong. I've just run this on the UK

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-04 Thread Mark Burton
Hi Charlie, I must be doing something wrong. I've just run this on the UK using --drive-on-left and --check-roundabouts and it seems to be flagging roundabouts that are correct (i.e. clock-wise). Here's some examples: 2009/10/04 19:16:31 WARNING (StyledConverter): Roundabout 4831867

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-04 Thread Charlie Ferrero
Mark Burton wrote: Hi Charlie, I must be doing something wrong. I've just run this on the UK using --drive-on-left and --check-roundabouts and it seems to be flagging roundabouts that are correct (i.e. clock-wise). Here's some examples: 2009/10/04 19:16:31 WARNING (StyledConverter):

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-03 Thread Charlie Ferrero
If there's a way you can share a pre-built jar file then I'd be happy to check it out as I spent ages fixing roundabouts in the Languedoc earlier this year. (Another common issue I've noticed is ways that don't meet: presumably these were made in Potlatch and the resolution isn't high enough

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-03 Thread Mark Burton
Hi Charlie, If there's a way you can share a pre-built jar file then I'd be happy to check it out as I spent ages fixing roundabouts in the Languedoc earlier this year. I've mailed one directly to you. (Another common issue I've noticed is ways that don't meet: presumably these were

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-03 Thread Paul
Mark Burton wrote: v5 - added --check-roundabouts option to explicitly enabled roundabout checking/reversing. Not had much feedback on this yet, anyone (apart from Dermot) tried it? Even if you don't drive on the left (almost the whole world?) you may care to try out the roundabout

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-03 Thread Mark Burton
Hi Paul, Either you've fixed all the GB roundabouts or I've done something wrong as I get no additional output when compiling a map of GB with this patch applied. If you have fixed them all then I see no negative side effects either I very much doubt that I've fixed every one so I think

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-03 Thread Paul
Mark Burton wrote: Hi Paul, Either you've fixed all the GB roundabouts or I've done something wrong as I get no additional output when compiling a map of GB with this patch applied. If you have fixed them all then I see no negative side effects either I very much doubt that I've fixed

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-03 Thread Mark Burton
Paul, I don't know about putting logging.properties into resources. I specify the file to use by giving this option to java: -Dlog.config=logging.properties However, the logging.properties file I quoted did have different levels of logging to the console and the log files, the console was less

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-03 Thread Paul
Mark Burton wrote: Paul, I don't know about putting logging.properties into resources. I specify the file to use by giving this option to java: -Dlog.config=logging.properties Yup. That did it. As the logging.properties in resources was the only file of that name I just presumed it was

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-03 Thread Dermot McNally
2009/10/3 Paul n...@pointdee.co.uk: Yup. That did it. As the logging.properties in resources was the only file of that name I just presumed it was the one to use That finally worked for me too. That revealed to me that there were in fact about 15 wrong-way roundabouts in Ireland. I'm happy to

Re: [mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-03 Thread Mark Burton
Hi Dermot, That finally worked for me too. That revealed to me that there were in fact about 15 wrong-way roundabouts in Ireland. I'm happy to say that there are now none at all :D Very good. One question, though - I'm also getting a few warnings like the following: 2009/10/03 15:06:21

[mkgmap-dev] [PATCH v5] - drive on left + roundabout direction checking

2009-10-02 Thread Mark Burton
v5 - added --check-roundabouts option to explicitly enabled roundabout checking/reversing. Not had much feedback on this yet, anyone (apart from Dermot) tried it? Even if you don't drive on the left (almost the whole world?) you may care to try out the roundabout checking. About 3% of all the GB