Re: [mkgmap-dev] tile takes very long time to generate

2021-04-29 Thread Ticker Berkin
Hi Gerd I'm away at moment, without full access to sources, so can't follow the current progress with partitioning, etc. Regarding finding a point IN (and not ON) polygon: 1/ Try bounds center. 2/ Assumed determined [counter-]clockwise from area calculation. Pick 3 sequential points, bisect

Re: [mkgmap-dev] tile takes very long time to generate

2021-04-29 Thread Gerd Petermann
n Gesendet: Dienstag, 27. April 2021 18:09 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Gerd Point IN and area should be adequate for determining enclosed/enclosing polygons relationships. Overlapping / intersecting is an error anyway,

Re: [mkgmap-dev] tile takes very long time to generate

2021-04-27 Thread Ticker Berkin
t; There are probably edge cases where this doesn't work, esp. when > > inners are very large. > > > > BTW: I found a bug in IsInUtil.isLineInShape() : It sometimes > > returns > > ON when it should return IN/ON > > I think it happens when a ring has start /end nod

Re: [mkgmap-dev] tile takes very long time to generate

2021-04-27 Thread Gerd Petermann
erd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Dienstag, 27. April 2021 15:37 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Gerd I'd have thought using isPointInShape() in combination with polygon ar

Re: [mkgmap-dev] tile takes very long time to generate

2021-04-27 Thread Ticker Berkin
Von: mkgmap-dev im Auftrag > von Ticker Berkin > Gesendet: Mittwoch, 7. April 2021 13:02 > An: Development list for mkgmap > Betreff: Re: [mkgmap-dev] tile takes very long time to generate > > Hi Gerd > > Problem is that IdentityHashMap is the ideal solution, but orderin

Re: [mkgmap-dev] tile takes very long time to generate

2021-04-26 Thread Gerd Petermann
ched patch fixes the problem in IsInUtil. Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Mittwoch, 7. April 2021 13:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Ger

Re: [mkgmap-dev] tile takes very long time to generate

2021-04-07 Thread Ticker Berkin
Hi Gerd Problem is that IdentityHashMap is the ideal solution, but ordering behaviour depends on internal java object handles. A solution to this stability issue would be to rotate joinedWays.originalWays so, say, the one with the lowest ID is first, doing this just before the full point -list is

Re: [mkgmap-dev] tile takes very long time to generate

2021-04-07 Thread Gerd Petermann
Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Dienstag, 6. April 2021 13:06 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Ticker, no need for another patch at the moment. I just try to make up my mind at what places

Re: [mkgmap-dev] tile takes very long time to generate

2021-04-06 Thread Gerd Petermann
Gesendet: Dienstag, 6. April 2021 12:59 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Gerd One of the ideas of the code is that it doesn't keep reversing all the points as it gets to joining the ways to make a polygon. Once all the ways have been

Re: [mkgmap-dev] tile takes very long time to generate

2021-04-06 Thread Ticker Berkin
that code? > > Gerd > > > Von: mkgmap-dev im Auftrag > von Ticker Berkin > Gesendet: Montag, 15. März 2021 17:15 > An: Development list for mkgmap > Betreff: Re: [mkgmap-dev] tile takes very long time to generate > > Hi Gerd > > You might consider

Re: [mkgmap-dev] tile takes very long time to generate

2021-04-06 Thread Gerd Petermann
Berkin Gesendet: Montag, 15. März 2021 17:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Gerd You might consider the some of the ideas here as improvements to the initial parts of MP processing. This is a patch based on trunk rather than

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-31 Thread Ticker Berkin
Hi Gerd I think this might be the reason why you backed out the Polish inner/outer definition changes: http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2019q1/029478.html Maybe there needs to be an option to say how multiple DATA{sameLevel} should be handled: a/ first outer, following inners. b/

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-31 Thread Gerd Petermann
for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Gerd Looking at the Polish format (cGPSmapper-UsrMan-v02.4.pdf), my understanding is that a polygon definition with multiple Data# statements at the same level defines a single outer with multiple inners (Page 20 and 74/5

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-31 Thread Ticker Berkin
__ > Von: mkgmap-dev im Auftrag > von Ticker Berkin > Gesendet: Dienstag, 30. März 2021 15:17 > An: Development list for mkgmap > Betreff: Re: [mkgmap-dev] tile takes very long time to generate > > Hi Gerd > > I'm revising my opinion abou

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-31 Thread Gerd Petermann
so far, but at least a lot less code... Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Dienstag, 30. März 2021 15:17 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Gerd I'm revising my

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-30 Thread Ticker Berkin
Hi Gerd I'm revising my opinion about considering the geometry to determine inner and outer. All the different BitSets, containsMatrix etc logic is too complex, and if it then conflicts with the explicit definition of the MP it just gets worse. I'd simpify it along these lines: split the

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-18 Thread Gerd Petermann
Hi Dave, thanks for the hint. I'll have a closer look at that country. Gerd Von: mkgmap-dev im Auftrag von Dave Gesendet: Donnerstag, 18. März 2021 12:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-18 Thread Dave
@lists.mkgmap.org.uk Reply to: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] tile takes very long time to generate Hi all, I still struggle with the unit test because it's hard to say what we want to get in special cases. The current code doesn't really work in the way that I expected. I always

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-18 Thread Gerd Petermann
With the correct role "outer" it is not ignored. No idea if this is intended or an error. Fortunately nested MP are very rare. Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Montag, 15. März 2021 17:15 An: Development list for mkgmap Betreff: Re

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-15 Thread Ticker Berkin
Hi Gerd You might consider the some of the ideas here as improvements to the initial parts of MP processing. This is a patch based on trunk rather than the new branch. It isn't structured as for final usage, rather for minimising the spread of changes, working in parallel with the existing code

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-15 Thread Gerd Petermann
list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Gerd Some possible test cases: Looking at the problems my code is detecting, the complicated cases are when possible polygons share 2 or more end-points with other possibles; for instance: http

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-15 Thread Ticker Berkin
Hi Gerd Some possible test cases: Looking at the problems my code is detecting, the complicated cases are when possible polygons share 2 or more end-points with other possibles; for instance: http://www.openstreetmap.org/relation/5329106 adjacent buildings, touching each other, are mapped as a

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-15 Thread Gerd Petermann
to find a good way to make the current code testable. Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Montag, 15. März 2021 09:50 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Gerd

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-15 Thread Ticker Berkin
imply ignore incomplete MP after logging a warning. > > Gerd > > > > Von: mkgmap-dev im Auftrag > von Ticker Berkin > Gesendet: Samstag, 13. März 2021 12:21 > An: Development list for mkgmap > Betreff: Re: [mkgmap-dev] tile takes very long time to generate > > Hi Ge

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-14 Thread Gerd Petermann
ould still be rendered somehow. Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Sonntag, 14. März 2021 09:47 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Ticker, the handling of the inner/

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-14 Thread Gerd Petermann
er Berkin Gesendet: Samstag, 13. März 2021 12:21 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Gerd I think the extra testing should be removed and the logic should work on the assumption of correct data; just emitting warning/errors whe

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-13 Thread Ticker Berkin
Hi Gerd I think the extra testing should be removed and the logic should work on the assumption of correct data; just emitting warning/errors when problems are found during the normal processing. It also has extra complexity due to early versions of the splitter not keeping relations/polygons

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-13 Thread Gerd Petermann
duce good results with correct data Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Donnerstag, 11. März 2021 07:58 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Ticker, I fear the pr

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-10 Thread Gerd Petermann
An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Gerd Having looked more closely at current OSM rules and what you said earlier in the thread about "old style" multipolygons and: https://wiki.openstreetmap.org/wiki/Old_style_multipolygons

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-10 Thread Ticker Berkin
is read, but the strange handling > of MP tags makes this useless. > > Gerd > > > Von: mkgmap-dev im Auftrag > von Gerd Petermann > Gesendet: Mittwoch, 10. März 2021 13:42 > An: Development list for mkgmap > Betreff: Re: [mkgmap-de

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-10 Thread Gerd Petermann
im Auftrag von Gerd Petermann Gesendet: Mittwoch, 10. März 2021 13:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Ticker, I think it would be good if we could defer the actions in method MultiPolygonRelation.processElements() until

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-10 Thread Gerd Petermann
Gesendet: Mittwoch, 10. März 2021 13:13 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi I'm not sure of all the rules regarding relations and resultant polygons and some of the MultiPolygonRelation.java code defeat me but some thoughts: Even though

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-10 Thread Ticker Berkin
nts/polygons. > > Any ideas besides hard coded "quick" solutions? > > Gerd > > > > > Von: mkgmap-dev im Auftrag > von Bernhard Hiller > Gesendet: Dienstag, 9. März 2021 09:50 > An: mkgmap-dev@lists.mkgmap.org

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-09 Thread Gerd Petermann
ard Hiller Gesendet: Dienstag, 9. März 2021 09:50 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Karl, some time ago, I stumbled upon a tile which took 2 hours(!) on my machine. With the "--polygon-file" option, the time could be reduced to

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-09 Thread Bernhard Hiller
Hi Karl, some time ago, I stumbled upon a tile which took 2 hours(!) on my machine. With the "--polygon-file" option, the time could be reduced to less than 100 s. See the old message in the archive: http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2017q1/026490.html and the thread "Performance with

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-09 Thread Gerd Petermann
n't render it. Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Dienstag, 9. März 2021 09:20 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi Karl, There are several ways to measure performanc

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-09 Thread Gerd Petermann
t style doesn't render place=sea. Gerd Von: mkgmap-dev im Auftrag von 7770 <7...@foskan.eu> Gesendet: Montag, 8. März 2021 19:17 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] tile takes very long time to generate Hi. I have uploaded the splitter output ht

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-08 Thread 7770
ou can also post them > here. Hope that helps. > > Gerd > > > > Von: mkgmap-dev im Auftrag von 7770 > <7...@foskan.eu> Gesendet: Montag, 8. März 2021 06:53 > An: mkgmap-dev@lists.mkgmap.org.uk > Betreff: [mkgmap-dev] tile takes very long time to ge

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-08 Thread Mike Baggaley
.eu> Gesendet: Montag, 8. März 2021 06:53 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] tile takes very long time to generate Hi. I observe a situation that one of the very first tiles (often the first or the third) that mkgmap generates takes 20 - 30 minutes to generate, wheres the

Re: [mkgmap-dev] tile takes very long time to generate

2021-03-07 Thread Gerd Petermann
Montag, 8. März 2021 06:53 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: [mkgmap-dev] tile takes very long time to generate Hi. I observe a situation that one of the very first tiles (often the first or the third) that mkgmap generates takes 20 - 30 minutes to generate, wheres the others take ab

[mkgmap-dev] tile takes very long time to generate

2021-03-07 Thread 7770
Hi. I observe a situation that one of the very first tiles (often the first or the third) that mkgmap generates takes 20 - 30 minutes to generate, wheres the others take about 30 seconds each. The map data produced by splitter is a total of around 700 files with splitter option