Re: [mkgmap-dev] Contour lines without elevation. What shoul mkgmap do?
Topical Garmin Bike headunits (Edge series) do elevation profiles for routes, but as far as I understand from DEM data, not contour lines, or? Would personally never use contour lines fir biking. These devices have a checkbox option to either displsy contour lines or not (if present in the map at all) in their firmware. I recently made successfull tests to render unpaved roads on the contour line types, to be able switch the same map between decluttered road and gravel use for bikes en route. Interesting hack. (Dunno which mkgmap version atm, am travelling). //Felix Original Message From: Gerd Petermann Sent: October 11, 2023 3:38:23 AM MST To: Development list for mkgmap Subject: Re: [mkgmap-dev] Contour lines without elevation. What shoul mkgmap do? Hi Ticker, my concern is that the data in the labels is also used to calculate a height profile when routing is enabled. Maybe this also depends on the --show-profiles option. Gerd On Wed, 2023-10-11 at 08:16 +, Gerd Petermann wrote: > Hi all, > >... > > I guess the same problem can happen with OSM data when a style uses the line > types 0x20 .. > 0x25 . > Should I add checks to warn when these line types are used without a proper > label that can be > elevation data? > > Gerd > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Contour lines without elevation. What shoul mkgmap do?
For my understanding is a missing elevation -value clearly a error. mkgmap shouldgive a hint and rejekt this line. 0x20...0x22 without value is not compatible with Garmin. See also Usermanual for cgpsmapper . regards thomas ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Contour lines without elevation. What shoul mkgmap do?
Ticker Berkin writes: > Looking at the code, there shouldn't be any crash from mkgmap if a contour > line doesn't have an > "ele" tag. I assume the Garmin device will just draw the appropriate line > without a label. This > might be common where alternate contours are not given heights. > > So, no; I don't think you should add any checks. I'm just barely reading list mail, but I agree with Ticker. A contour line without an elevation still makes sense, at least enough sense that it shouldn't be rejected. However, I don't really grasp Gerd's comment about elevations used for routing. Presumably that is in some newfangled Garmin device that proceses a route with respect to contours? If so, then I see how this is really hard, choosing between: reject accept accept only if some flag is or isn't given, to be set depending on if one is building maps for routing/elevation devices ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Contour lines without elevation. What shoul mkgmap do?
Hi Ticker, my concern is that the data in the labels is also used to calculate a height profile when routing is enabled. Maybe this also depends on the --show-profiles option. Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Mittwoch, 11. Oktober 2023 11:51 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Contour lines without elevation. What shoul mkgmap do? Hi Gerd Looking at the code, there shouldn't be any crash from mkgmap if a contour line doesn't have an "ele" tag. I assume the Garmin device will just draw the appropriate line without a label. This might be common where alternate contours are not given heights. So, no; I don't think you should add any checks. Ticker On Wed, 2023-10-11 at 08:16 +, Gerd Petermann wrote: > Hi all, > > in a private mail I was informed that mkgmap crashes when polish input > contains no label for > types which are considered as contour line data like this > [POLYLINE] > Type=0x20 > Data0=(51.5300781,-0.0988259), (51.5305501,-0.0989852), > (51.5311576,-0.0992174) > [END] > > The same data was handled without problem before r4907. > As a quick hack I've added a null check to restore the old behaviour, but I > wonder if it would > be better to stop with an error message > or maybe ignore contour line data when no elevation is given in the label? > > I guess the same problem can happen with OSM data when a style uses the line > types 0x20 .. > 0x25 . > Should I add checks to warn when these line types are used without a proper > label that can be > elevation data? > > Gerd > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Contour lines without elevation. What shoul mkgmap do?
Hi Gerd Looking at the code, there shouldn't be any crash from mkgmap if a contour line doesn't have an "ele" tag. I assume the Garmin device will just draw the appropriate line without a label. This might be common where alternate contours are not given heights. So, no; I don't think you should add any checks. Ticker On Wed, 2023-10-11 at 08:16 +, Gerd Petermann wrote: > Hi all, > > in a private mail I was informed that mkgmap crashes when polish input > contains no label for > types which are considered as contour line data like this > [POLYLINE] > Type=0x20 > Data0=(51.5300781,-0.0988259), (51.5305501,-0.0989852), > (51.5311576,-0.0992174) > [END] > > The same data was handled without problem before r4907. > As a quick hack I've added a null check to restore the old behaviour, but I > wonder if it would > be better to stop with an error message > or maybe ignore contour line data when no elevation is given in the label? > > I guess the same problem can happen with OSM data when a style uses the line > types 0x20 .. > 0x25 . > Should I add checks to warn when these line types are used without a proper > label that can be > elevation data? > > Gerd > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] Contour lines without elevation. What shoul mkgmap do?
Hi all, in a private mail I was informed that mkgmap crashes when polish input contains no label for types which are considered as contour line data like this [POLYLINE] Type=0x20 Data0=(51.5300781,-0.0988259), (51.5305501,-0.0989852), (51.5311576,-0.0992174) [END] The same data was handled without problem before r4907. As a quick hack I've added a null check to restore the old behaviour, but I wonder if it would be better to stop with an error message or maybe ignore contour line data when no elevation is given in the label? I guess the same problem can happen with OSM data when a style uses the line types 0x20 .. 0x25 . Should I add checks to warn when these line types are used without a proper label that can be elevation data? Gerd ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
