Re: [mkgmap-dev] bugreport for new splitter

2009-08-09 Thread Chris Miller
I still wonder if the problem is with Geofabrik, and not with splitter? I haven't started digging into this bug yet but superficially at least it does appear to be a problem with some of the new code in the splitter. Possibly the problem is triggered by malformed XML, but more likely I think

Re: [mkgmap-dev] Commit: r1125: Ant task for mkgmap

2009-08-09 Thread Christian Gawron
svn commit schrieb: Version 1125 was commited by steve on 2009-08-09 13:10:22 +0100 (Sun, 09 Aug 2009) Ant task for mkgmap. As submitted by Christian Gawron. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk

Re: [mkgmap-dev] [PATCH v3] sea polygons

2009-08-09 Thread Christian Gawron
Dear Maning, the problem is most probably that I assumed that the intersection between the land mass and the bounding box is simply connected. I won't be able to fix this today, but you could add if (!it1.hasNext()) break; before the offending line 860 EdgeHit h1 =

Re: [mkgmap-dev] [PATCH v3] sea polygons

2009-08-09 Thread Christian Gawron
Dear Dermot, the triangle artifacts have to do with the multipolygon code. There is a comment by someone saying //with this line commented we get triangles, when uncommented some areas disappear // at least in mapsource, on device itself looks OK. The multiploygon code connects

Re: [mkgmap-dev] bugreport for new splitter

2009-08-09 Thread Chris Miller
Have a try with splitter r65, I've just checked in a fix that should solve your problem. I reran it against today's europe.osm and it completed successfully: .. 12,000,000 ways processed... Writing relations Sun Aug 09 14:19:27 BST 2009 50,000 relations processed... 100,000 relations

Re: [mkgmap-dev] Commit: r1125: Ant task for mkgmap

2009-08-09 Thread Steve Ratcliffe
On 09/08/09 13:25, Christian Gawron wrote: Thanks for adding the Ant task! No problem. I am going to change though it so that it doesn't require making a bunch of methods public on the command line reader. Maybe it's a good idea to move the GeoTIFF stuff in the extra-dir, too. Yes, that is

Re: [mkgmap-dev] bugreport for new splitter

2009-08-09 Thread Chris Miller
Hmm, running with max-nodes=30 on r65 now makes it further, but fails with another (related) problem. I'm going to try and find the problematic way(s)/relation(s) so I can make a test case. Please hold off on big splits with r65 for now. Have a try with splitter r65, I've just checked in

[mkgmap-dev] Commit: r1127: Move ant task to its original package.

2009-08-09 Thread svn commit
Version 1127 was commited by steve on 2009-08-09 16:24:54 +0100 (Sun, 09 Aug 2009) Move ant task to its original package. Fix finding style off the class path for the ant task. Modified ant task to not require changes to the public interface of the argument reader. Document the long form of

[mkgmap-dev] [PATCH v3] - styling for the power user

2009-08-09 Thread Mark Burton
v3 Now only has 1 tag (mkgmap:gtype) to specify everything. tag has the format 'kind,code,minres,maxres,roadclass,roadspeed' Where kind is 1 for node, 2 for polyline and 3 for polygon. kind, code and minres are all required to be present, the other values can be ommitted. Note, this format

Re: [mkgmap-dev] [PATCH v2] - styling for the power user

2009-08-09 Thread Mark Burton
Hi Garvan, Thanks for the feedback. I tested this patch today, and it worked as advertised. Thanks for your work. Good. I have a suggestion. Would it be better to use tag k=mkgmap:gtype v=0x06,21,,1,2/ instead of tag k=mkgmap:gtype=0x06,21,,1,2/ I know nothing about osm format,

[mkgmap-dev] Multipolygons

2009-08-09 Thread Steve Ratcliffe
Hi I am going to merge all the multipolygon fixes. Including, if appropriate, the sea polygon changes. In addition to the patches sent to the list I also have permission to use the attached patch from Olaf Kähler which he describes as follows: I guess, mkgmap has a bug with vanishing islands

Re: [mkgmap-dev] Suggestions: improvements to mkgmap --style-file= and --list-styles options

2009-08-09 Thread Greg Troxel
Charlie Ferrero char...@cferrero.net writes: 1. Currently, if you invoke mkgmap with the --style-file= tag and point to a non-existent style file (or incorrect path), mkgmap continues regardless (and applies the inbuilt default style, afaict). Can I suggest a patch to mkgmap that at

Re: [mkgmap-dev] Suggestions: improvements to mkgmap --style-file= and --list-styles options

2009-08-09 Thread Steve Ratcliffe
On 09/08/09 18:41, Charlie Ferrero wrote: 1. Currently, if you invoke mkgmap with the --style-file= tag and point to a non-existent style file (or incorrect path), mkgmap continues regardless (and applies the inbuilt default style, afaict). Can I suggest a patch to mkgmap that at least

[mkgmap-dev] Commit: r1129: Fix disapearing multipolys if the first point happens to be the closest.

2009-08-09 Thread svn commit
Version 1129 was commited by steve on 2009-08-09 23:14:56 +0100 (Sun, 09 Aug 2009) BRANCH: multipolygon Fix disapearing multipolys if the first point happens to be the closest. Modifed from patch sent by Christian, as -1 is technically a possible return value.

Re: [mkgmap-dev] bugreport for new splitter

2009-08-09 Thread Chris Miller
How does a node get to be in more than four areas? ..Steve Good question, I was wondering that myself. It looks like with so few nodes per area, we end up with some very thin areas that for example result in the two areas on each side, plus two adjacent areas above, being included in the

Re: [mkgmap-dev] [PATCH v3] sea polygons

2009-08-09 Thread maning sambale
On Sun, Aug 9, 2009 at 9:09 PM, Christian Gawronchristian.gaw...@gmx.de wrote: Dear Maning, the problem is most probably that I assumed that the intersection between the land mass and the bounding box is simply connected. Yes this is the case. I won't be able to fix this today, but you could