Re: [mkgmap-dev] Commit: r1265: Added --drive-on-left, --drive-on-right and --check-roundabouts options.
0 In article 20091020141739.184f9...@crow, 0 Mark Burton URL:mailto:ma...@ordern.com (Mark) wrote: Mark For the GB data, enabling that test gives over 2000 warnings, the Mark vast majority of which are real problems that either break the Mark routing completely or at least give odd routes. I am (slowly) Mark editing the OSM data to fix the problems. It's incredible what Mark crap people are happy to put into the OSM database. I get the Mark impression that most contributors don't give a toss about the map Mark being routable or not. Whilst that's certainly at least partially true, it's also the case that editing tools can change more than users expect. I've caused at least broken roundabouts myself when joining ways and not noticing that that has reversed their directions. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Commit: r1265: Added --drive-on-left, --drive-on-right and --check-roundabouts options.
Hi Marko, Thanks, with the logging.properties from http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2009q3/003993.html I got some warnings about roundabouts and fixed a few already. Good, glad it's useful to you. I did not find the old discussion on a problematic roundabout, so I cannot check the data. I am just guessing that the problem could be that the roundabout segments were not tagged junction=roundabout (because some validator or renderer could have problems with roundabouts defined in multiple segments). That would be an error of the validator or renderer, of course. Splitting roundabouts into segments is very common in the UK because of route relations. i.e. a bus route uses part of a roundabout and so the roundabout is split into segments so that only a portion of the roundabout is part of the bus route. You may also wish to try out the new --check-roundabout-flares option which checks that roundabout flare roads are sane (oneway, point in the right directions and don't extend further than they need to). For the GB data, enabling that test gives over 2000 warnings, the vast majority of which are real problems that either break the routing completely or at least give odd routes. I am (slowly) editing the OSM data to fix the problems. It's incredible what crap people are happy to put into the OSM database. I get the impression that most contributors don't give a toss about the map being routable or not. Cheers, Mark ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Commit: r1265: Added --drive-on-left, --drive-on-right and --check-roundabouts options.
On Tue, Oct 06, 2009 at 09:30:02PM +0100, svn commit wrote: Version 1265 was commited by markb on 2009-10-06 21:30:02 +0100 (Tue, 06 Oct 2009) Added --drive-on-left, --drive-on-right and --check-roundabouts options. --drive-on-left --drive-on-right Explicitly specify which side of the road vehicles are expected to drive on. If neither of these options are specified, it is assumed that vehicles drive on the right unless --check-roundabouts is specified and the first roundabout processed is clockwise. --check-roundabouts Check that roundabouts have the expected direction (clockwise when vehicles drive on the left). Roundabouts that are complete loops and have the wrong direction are reversed. I tried --drive-on-right --check-roundabouts, and the generated map is of the same size as with r1260. There are much more diffs than the time stamps, though. This is with 3 tiles and 2 cores. I did not get any warnings or messages on stdout or stderr, or any assertion failures. Does this mean that Finland is OK? Or should I enable some magic logging property to see the errors? One more question: What about roundabouts that have been split because of bus route relations (bus routes would usually not circle the whole roundabout)? Does mkgmap merge them already? Could it? Would some style tagging be needed, in case someone wants to do special line styles or naming based on bus routes? Best regards, Marko ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Commit: r1265: Added --drive-on-left, --drive-on-right and --check-roundabouts options.
Hi Marko, I tried --drive-on-right --check-roundabouts, and the generated map is of the same size as with r1260. There are much more diffs than the time stamps, though. This is with 3 tiles and 2 cores. The code that calculates the arc headings is probably producing a slightly different result (+/- 1 deg) so it's possible that's what all the changes are (if so, not a problem). I did not get any warnings or messages on stdout or stderr, or any assertion failures. Does this mean that Finland is OK? Or should I enable some magic logging property to see the errors? Yes, you need to have a logging.properties file (see previous postings) that enables logging for warnings either to the console or to log files. One more question: What about roundabouts that have been split because of bus route relations (bus routes would usually not circle the whole roundabout)? Does mkgmap merge them already? Could it? Would some style tagging be needed, in case someone wants to do special line styles or naming based on bus routes? The roundabout checking code tries to check roundabout segments and will report any that it thinks have the wrong direction but it will not reverse any because the check can be fooled. I checked all the roundabouts on the GB mainland and quite a few segmented roundabouts that had segments going in the wrong direction where detected. Quite often, ways get the junction=roundabout tag by mistake (i.e. the're not actually part of a roundabout) and the check will find around 50% of those errors. Cheers, Mark ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Commit: r1265: Added --drive-on-left, --drive-on-right and --check-roundabouts options.
Quoting Marko Mäkelä marko.mak...@iki.fi: On Tue, Oct 06, 2009 at 09:30:02PM +0100, svn commit wrote: Version 1265 was commited by markb on 2009-10-06 21:30:02 +0100 (Tue, 06 Oct 2009) Added --drive-on-left, --drive-on-right and --check-roundabouts options. --drive-on-left --drive-on-right Explicitly specify which side of the road vehicles are expected to drive on. If neither of these options are specified, it is assumed that vehicles drive on the right unless --check-roundabouts is specified and the first roundabout processed is clockwise. --check-roundabouts Check that roundabouts have the expected direction (clockwise when vehicles drive on the left). Roundabouts that are complete loops and have the wrong direction are reversed. I tried --drive-on-right --check-roundabouts, and the generated map is of the same size as with r1260. There are much more diffs than the time stamps, though. This is with 3 tiles and 2 cores. I did not get any warnings or messages on stdout or stderr, or any assertion failures. Does this mean that Finland is OK? Or should I enable some magic logging property to see the errors? You need to enable java logging: see http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2009q3/003993.html ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
