[Mlt-devel] Optimizing Qt functions

2016-07-16 Thread Jean-Baptiste Mardelle
Hi, Following my tests with the qtblend transitions, I realized that the QImage format Format_RGBA allows for a much simpler conversion between MLT and QImage, avoiding the need to copy data. We can in fact simply create a QImage directly from MLT's image buffer (with format=mlt_image_rgb24

Re: [Mlt-devel] Optimizing Qt functions

2016-07-16 Thread Brian Matherly
I think this would be a good optimization. QImage::Format_RGBA is not available in Qt 4.8. So we would need some pre-processor conditionals to use either the previous way or the new way depending on version. Are you sure that line order is the same between Qt and MLT image formats? For some

Re: [Mlt-devel] Optimizing Qt functions

2016-07-16 Thread Jean-Baptiste Mardelle
On Saturday, July 16, 2016 7:02:25 PM CEST, Brian Matherly wrote: > I think this would be a good optimization. > > QImage::Format_RGBA is not available in Qt 4.8. So we would > need some pre-processor conditionals to use either the previous > way or the new way depending on version. Oh, righ

Re: [Mlt-devel] Optimizing Qt functions

2016-07-16 Thread Brian Matherly
> Oh, right. I used it in my qtblend transition - than I guess I will enable > it only on Qt5. I would prefer to see copy_qimage_to_mlt_rgba() modified to use it with a conditional to check QT version at compile time. > I can confirm that you can draw text directly on the QImage > (Format_R

Re: [Mlt-devel] Optimizing Qt functions

2016-07-16 Thread Dan Dennedy
On Sat, Jul 16, 2016 at 11:37 AM Jean-Baptiste Mardelle wrote: > On Saturday, July 16, 2016 7:02:25 PM CEST, Brian Matherly wrote: > > Are you sure that line order is the same between Qt and MLT > > image formats? For some reason I was thinking that line 0 is the > The image line order is the sa

Re: [Mlt-devel] Optimizing Qt functions

2016-07-16 Thread Jean-Baptiste Mardelle
On Saturday, July 16, 2016 8:57:49 PM CEST, Brian Matherly wrote: > >> Oh, right. I used it in my qtblend transition - than I guess I >> will enable >> it only on Qt5. > > I would prefer to see copy_qimage_to_mlt_rgba() modified to use > it with a conditional to check QT version at compile time

Re: [Mlt-devel] Optimizing Qt functions

2016-07-16 Thread Dan Dennedy
I am OK with you to commit your changes and additions. Configure should let you pass CXXFLAGS set from the environment. On Sat, Jul 16, 2016, 3:56 PM Jean-Baptiste Mardelle wrote: > On Saturday, July 16, 2016 8:57:49 PM CEST, Brian Matherly wrote: > > > > >> Oh, right. I used it in my qtblend tr