Re: [Mlt-devel] [PATCH 1/3] fix a audiostream leak in producer reopen
03.07.11 23:06, Dan Dennedy написав(ла): On Sun, Jul 3, 2011 at 12:48 PM, Maksym Veremeyenkove...@m1stereo.tv wrote: On Sun, July 3, 2011 10:01 pm, Dan Dennedy wrote: 2011/7/3 Maksym Veremeyenkove...@m1stereo.tv: Hi, playing files in a loop mode in melted cause a leak of file descriptors that seen well from /proc/process id/fd/file no. the problem comes from avformat's producer re-open code that lost release of audiostream context. attached patch fix this behaviour... This patch is wrong in a couple of ways. It completely alters the locking mechanisms, and I will be surprised if it works under multi-threaded access such as with kdenlive or with parallel consumer. Your attempt to refactor to common code is noble but naive with respect to the locking requirements, which are different depending upon the state of the locks when these similar actions are invoked. Secondly, it breaks the user-selected audio and video tracks because in producer_open() they are reset to their defaults. That is why they were saved before producer_open() and re-applied afterwards. updated patch attached Please test my latest commits. In my analysis and testing while working on these fixes, I found it is not at all safe to close the audio format and codec contexts at this point - think parallel. there are no leaks noticed with latest git, thanks. No offense to you, but I am not too comfortable with other people's hands getting into avformat producer. That is a very intricate piece of work, and there are a lot of special requirements that only I know about. Thank you for trying, though! It will be nice for someone else to become knowledgeable about this code. If you look at the git log, you will see that I have put major effort to refactoring its code periodically in order to tame this wild beast. If you want to contribute something here, I would accept a patch that refactors my recent change that added a take_lock parameter to producer_open() into a new function producer_open_with_lock() that inside calls producer_open() - similar approach to your patch. ok -- Maksym Veremeyenko -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [PATCH 1/3] fix a audiostream leak in producer reopen
03.07.11 23:06, Dan Dennedy написав(ла): On Sun, Jul 3, 2011 at 12:48 PM, Maksym Veremeyenkove...@m1stereo.tv wrote: On Sun, July 3, 2011 10:01 pm, Dan Dennedy wrote: 2011/7/3 Maksym Veremeyenkove...@m1stereo.tv: Hi, playing files in a loop mode in melted cause a leak of file descriptors that seen well from /proc/process id/fd/file no. the problem comes from avformat's producer re-open code that lost release of audiostream context. [...] Please test my latest commits. In my analysis and testing while working on these fixes, I found it is not at all safe to close the audio format and codec contexts at this point - think parallel. i am not sure it it regression or related, but something influent a decklink output, to be precise, out output. After hour or two i start receive messages about decklink audio buffer underflow - it wrote less samples then 1920 -- Maksym Veremeyenko -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
[Mlt-devel] Git: Add convenient reconfigure script.
reconfigure |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) New commits: commit 8251f682a8262ac3a16c4358d19ef51c85dc794c Author: Dan Dennedy d...@dennedy.org Date: Mon Jul 4 10:39:53 2011 -0700 Add convenient reconfigure script. -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
[Mlt-devel] Git: Dropping support for --avformat-svn.
src/modules/avformat/Makefile | 16 + src/modules/avformat/configure | 78 +-- 2 files changed, 11 insertions(+), 83 deletions(-) New commits: commit a4eff985c6d282da8a50b1fd17926f0261cb48fa Author: Dan Dennedy d...@dennedy.org Date: Mon Jul 4 18:23:51 2011 -0700 Dropping support for --avformat-svn. Subversion is no longer used, FFmpeg and libav have forked, and now there are the build scripts. -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
[Mlt-devel] Git: Suppress confusing message when vpre does not exist.
src/modules/avformat/consumer_avformat.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) New commits: commit 9403f197ca13a2433afdea4d2394e022a3294661 Author: Dan Dennedy d...@dennedy.org Date: Mon Jul 4 21:16:53 2011 -0700 Suppress confusing message when vpre does not exist. -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
[Mlt-devel] Git: Skip audio output with first pass.
presets/consumer/avformat/x264-medium-pass1 |1 + 1 files changed, 1 insertions(+), 0 deletions(-) New commits: commit 452d80fe6cb8f198f904027460ae708b3261a4a3 Author: Dan Dennedy d...@dennedy.org Date: Mon Jul 4 21:19:31 2011 -0700 Skip audio output with first pass. -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
[Mlt-devel] Git: Cleanup display of recommended versions.
src/modules/avformat/configure |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) New commits: commit 520c3cf478cb312418ba2b9c51aa2873025c675a Author: Dan Dennedy d...@dennedy.org Date: Mon Jul 4 21:24:18 2011 -0700 Cleanup display of recommended versions. -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
