Re: [Mlt-devel] Recent change to comsumer_xml corrupts projects
On Mon, Jun 18, 2018 at 4:42 AM Jean-Baptiste Mardelle wrote: > Hi all, > > > Hope you are doing fine and great to see the recent activity on MLT. One > recent change causes problems in Kdenlive and will also in other > applications: > > > https://github.com/mltframework/mlt/commit/c091cae3a34fe9046e7ed610bd64d2df3c11dfe0 > > With this change, any property containing an "=" sign will be converted > to animation. However, this is not wanted in some cases, for example if > you want to display a text with an equal sign: > > melt -consumer qtext text="frame=1" -consumer xml > > This will change the text to "0=1" because it tries to translate the > text string to an animation property. This also currently breaks > kdenlivetitle producer because it stores some xml data, including equal > signs, in the "xmldata" property. > > Maybe this animation parsing should not be done on "string" type > properties? Any idea? > Thank you for finding and reporting the regression! I believe I fixed it by removing the code bits following: // Force a string with keyframes to be parsed with mlt_animation ... As a result, one cannot supply an animated property by a string and get it converted to another clock string format without some intervention to cause the property to be evaluated as animation (by getting its value at a position). It should be noted that string properties can be animated ala timed text- only with no interpolation. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
[Mlt-devel] [mltframework/mlt] 3e3c5f: Fix serializing non-animation strings with '='.
Branch: refs/heads/master Home: https://github.com/mltframework/mlt Commit: 3e3c5fffcc351e556fc48bee83a80aa3918c3718 https://github.com/mltframework/mlt/commit/3e3c5fffcc351e556fc48bee83a80aa3918c3718 Author: Dan Dennedy Date: 2018-06-18 (Mon, 18 Jun 2018) Changed paths: M src/modules/xml/consumer_xml.c Log Message: --- Fix serializing non-animation strings with '='. Regression in c091cae3a34fe9046e7ed610bd64d2df3c11dfe0 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
[Mlt-devel] Recent change to comsumer_xml corrupts projects
Hi all, Hope you are doing fine and great to see the recent activity on MLT. One recent change causes problems in Kdenlive and will also in other applications: https://github.com/mltframework/mlt/commit/c091cae3a34fe9046e7ed610bd64d2df3c11dfe0 With this change, any property containing an "=" sign will be converted to animation. However, this is not wanted in some cases, for example if you want to display a text with an equal sign: melt -consumer qtext text="frame=1" -consumer xml This will change the text to "0=1" because it tries to translate the text string to an animation property. This also currently breaks kdenlivetitle producer because it stores some xml data, including equal signs, in the "xmldata" property. Maybe this animation parsing should not be done on "string" type properties? Any idea? Thanks Jean-Baptiste -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
