Thanks JB, you are correct! I will make a v6.26.1 release for this.
On Tue, Apr 13, 2021 at 9:23 AM Jean-Baptiste Mardelle
wrote:
> Hi all,
>
> I just wanted to let you know I just discovered that playing remote files
> does
> not work anymore with MLT and results in a crash, due to this commit:
>
> https://github.com/mltframework/mlt/commit/
> d769db2427823f65cba4e097b7fef8a5a8a77469#diff-
> dd4dd7f8b6c28984ac8e670241eb3a0e5ddc65efa5c2784a7267a018d6ff6811
>
> To reproduce:
> melt http://techslides.com/demos/sample-videos/small.mp4
> Crashes with MLT 6.26
>
> The below patch (restoring the avio_check) fixes the problem and crash,
> above
> line correctly plays the video, but not sure it's wanted or the best way.
> Anyways, we should at least try to fix the crash.
>
> Best regards,
> Jean-Baptiste
>
> diff --git a/src/modules/avformat/producer_avformat.c
> b/src/modules/avformat/
> producer_avformat.c
> index 6628978f..d5869fed 100644
> --- a/src/modules/avformat/producer_avformat.c
> +++ b/src/modules/avformat/producer_avformat.c
> @@ -544,7 +544,7 @@ static char* parse_url( mlt_profile profile, const
> char*
> URL, AVInputFormat **fo
> char *url = strchr( protocol, ':' );
>
> // Truncate protocol string
> - if (url && url - protocol > 1) { // if defined and not a drive
> letter
> + if (url && url - protocol > 1 && avio_check( URL, 0 ) < 0) { // if
> defined and not a drive letter
> url[0] = '\0';
> ++url;
> mlt_log_debug( NULL, "%s: protocol=%s resource=%s\n",
> __FUNCTION__, protocol, url );
>
>
>
>
___
Mlt-devel mailing list
Mlt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mlt-devel
