Re: [Mlt-devel] [PATCH] use rational fps value to calc frames count
30.07.13 07:38, Dan Dennedy написав(ла): On Sun, Jul 21, 2013 at 6:33 AM, Maksym Veremeyenkove...@m1stereo.tv wrote: Hi, recently i noticed that all clips i was trying to play with mlt has duration 1 smaller then origin. this happens because of calculation (or even compiler) of frames count that comes on double and later not rounded to integer. [...] attached patch tries to avoid double type using during calculation and properly return 251 frames length... -- Maksym Veremeyenko looks good to me, thanks, applied. is it possible to ask to test if regression of /mlt_position type double/ disappeared after that patch? -- Maksym Veremeyenko -- Get your SQL database under version control now! Version control is standard for application code, but databases havent caught up. So what steps can you take to put your SQL databases under version control? Why should you start doing it? Read more to find out. http://pubads.g.doubleclick.net/gampad/clk?id=49501711iu=/4140/ostg.clktrk ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [PATCH] use rational fps value to calc frames count
On Jul 29, 2013 11:23 PM, Maksym Veremeyenko ve...@m1stereo.tv wrote: 30.07.13 07:38, Dan Dennedy написав(ла): On Sun, Jul 21, 2013 at 6:33 AM, Maksym Veremeyenkove...@m1stereo.tv wrote: Hi, recently i noticed that all clips i was trying to play with mlt has duration 1 smaller then origin. this happens because of calculation (or even compiler) of frames count that comes on double and later not rounded to integer. [...] attached patch tries to avoid double type using during calculation and properly return 251 frames length... -- Maksym Veremeyenko looks good to me, thanks, applied. is it possible to ask to test if regression of /mlt_position type double/ disappeared after that patch? Sorry, but I do not understand your question. -- Get your SQL database under version control now! Version control is standard for application code, but databases havent caught up. So what steps can you take to put your SQL databases under version control? Why should you start doing it? Read more to find out. http://pubads.g.doubleclick.net/gampad/clk?id=49501711iu=/4140/ostg.clktrk___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [PATCH] use rational fps value to calc frames count
On Mon, Jul 29, 2013 at 11:32 PM, Maksym Veremeyenko ve...@m1stereo.tv wrote: 30.07.13 09:26, Dan Dennedy написав(ла): On Jul 29, 2013 11:23 PM, Maksym Veremeyenko ve...@m1stereo.tv mailto:ve...@m1stereo.tv wrote: [...] is it possible to ask to test if regression of /mlt_position type double/ disappeared after that patch? Sorry, but I do not understand your question. i noticed *Fix default type for mlt_position regression in commit 7601aa4.* (https://github.com/mltframework/mlt/commit/2cb405ac3d392f6ecb5a33b096e11265ba832a8d) that reverts DOUBLE_MLT_POSITION changes because of some regressions. I also noticed that regressions some days ago but $subj seems to me fix that. I would like to ask to perform one more test to check if regression of DOUBLE_MLT_POSITION still present. I do not support mlt_position as double, and I do not test it as such. That is simply too big of a change to impose on all of the MLT applications. Therefore, your patch that defined DOUBLE_MLT_POSITION by default was the regression that I reverted by the commit that you referenced above. That is the only regression I was referring to: defining that by default. You are free to build MLT with that defined and to test that it works ok for your needs. I just committed a change to make it easier for you and others to to include -DDOUBLE_MLT_POSITION in CFLAGS when you build: -#undef DOUBLE_MLT_POSITION I hope that satisfies your needs. -- +-DRD-+ -- Get your SQL database under version control now! Version control is standard for application code, but databases havent caught up. So what steps can you take to put your SQL databases under version control? Why should you start doing it? Read more to find out. http://pubads.g.doubleclick.net/gampad/clk?id=49501711iu=/4140/ostg.clktrk ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
