Re: Good news, bad news

2011-05-19 Thread Ola Bini
On 2011-05-20 11.21, John Rose wrote: > On May 19, 2011, at 10:06 PM, Charles Oliver Nutter wrote: > >> I've confimed that the i386 build performs just as poorly. Have not >> investigate at inlining or assembly level yet...and it's late, so I'm >> going to get some sleep. > > It's likely that met

Re: Good news, bad news

2011-05-19 Thread John Rose
On May 19, 2011, at 10:06 PM, Charles Oliver Nutter wrote: > I've confimed that the i386 build performs just as poorly. Have not > investigate at inlining or assembly level yet...and it's late, so I'm > going to get some sleep. It's likely that method handle inlining is failing. Try -XX:+UnlockD

Re: Good news, bad news

2011-05-19 Thread Charles Oliver Nutter
On Thu, May 19, 2011 at 11:25 PM, Charles Oliver Nutter wrote: > Ok, good news first. The recent drop of fixes from Hotspot seem to > have fixed the problems in methodHandleWalk.cpp. Hooray! > > The bad news is that performance seems to have *severely* degrade > since previous builds. I've confim

Re: Good news, bad news

2011-05-19 Thread Ola Bini
On 2011-05-20 09.55, Charles Oliver Nutter wrote: > Ok, good news first. The recent drop of fixes from Hotspot seem to > have fixed the problems in methodHandleWalk.cpp. Hooray! Sorry, but we still have bad news. Specifically, two failures. First a new ShouldNotReachHere crash: # # A fatal error h

Good news, bad news

2011-05-19 Thread Charles Oliver Nutter
Ok, good news first. The recent drop of fixes from Hotspot seem to have fixed the problems in methodHandleWalk.cpp. Hooray! The bad news is that performance seems to have *severely* degrade since previous builds. Here's JRuby running something simple, the fib benchmark: ~/projects/jruby ➔ jruby

hg: mlvm/mlvm/hotspot: meth: reflect pushes to hotspot-comp (fix MHW)

2011-05-19 Thread john . r . rose
Changeset: 8218383d4205 Author:jrose Date: 2011-05-19 15:46 -0700 URL: http://hg.openjdk.java.net/mlvm/mlvm/hotspot/rev/8218383d4205 meth: reflect pushes to hotspot-comp (fix MHW) ! meth-mhw-7045513.patch ___ mlvm-dev mailing list mlvm-d

Re: Inserting pre and post-call logic around a handle?

2011-05-19 Thread John Rose
On May 19, 2011, at 2:08 PM, Charles Oliver Nutter wrote: > Basically, I want the MH chain to contain all pre/post logic in a > try/finally form wrapped around the eventual direct handle, since > ping-ponging through a generalized piece of code for many different > targets would produce a polymorp

Re: SwitchPoint-based constant lookup in JRuby

2011-05-19 Thread Charles Oliver Nutter
On Thu, May 19, 2011 at 4:00 PM, John Rose wrote: > Cool!  That's one of the key use cases for SwitchPoint envisioned by the > Expert Group.  Please tell us ASAP if something goes wrong with the API! >  (The implementation we can fix, but the API is going more cryogenic as each > day passes.) Onl

Re: Inserting pre and post-call logic around a handle?

2011-05-19 Thread Charles Oliver Nutter
On Thu, May 19, 2011 at 3:53 PM, John Rose wrote: > If you do a fold with a void return, nothing gets inserted into the argument > list. > > The doc for this needs to be fixed, but the implementation should work now. Hah...the original subject of my email was "foldArguments with void return poss

Re: SwitchPoint-based constant lookup in JRuby

2011-05-19 Thread John Rose
On May 19, 2011, at 11:11 AM, Charles Oliver Nutter wrote: > I've just landed a newer SwitchPoint-based constant caching mechanism. > > https://github.com/jruby/jruby/commit/90be178c96053d201ea2a869bda7feddeedcfa10 Cool! That's one of the key use cases for SwitchPoint envisioned by the Expert

Re: Inserting pre and post-call logic around a handle?

2011-05-19 Thread John Rose
On May 19, 2011, at 12:53 PM, Charles Oliver Nutter wrote: > I have cases where I want to do some pre and post-call logic around a > target handle. Basically, I need to twiddle some global state before > and after to set up one of our artificial call frames for the target > method to use. How coul

Inserting pre and post-call logic around a handle?

2011-05-19 Thread Charles Oliver Nutter
I have cases where I want to do some pre and post-call logic around a target handle. Basically, I need to twiddle some global state before and after to set up one of our artificial call frames for the target method to use. How could I do this in handles? The logic basically looks like this: preLo

SwitchPoint-based constant lookup in JRuby

2011-05-19 Thread Charles Oliver Nutter
In Ruby, constants...aren't. They're *mostly* constant, but they have to be looked up dynamically via the lexical scope and self class hierarchy. They can be changed after the fact, and class modifications like mixing in a module later will change the scenery, but these sorts of changes are very ra

Re: Limit on number of inserted values in MHs?

2011-05-19 Thread Ola Bini
On 2011-05-19 23.23, Charles Oliver Nutter wrote: > On Thu, May 19, 2011 at 12:51 PM, Ola Bini wrote: >> I'm currently getting this error: >> >> Caused by: java.lang.IllegalArgumentException: too many values to insert >>at >> java.lang.invoke.MethodHandleStatics.newIllegalArgumentException

Re: Limit on number of inserted values in MHs?

2011-05-19 Thread Charles Oliver Nutter
On Thu, May 19, 2011 at 12:51 PM, Ola Bini wrote: > I'm currently getting this error: > > Caused by: java.lang.IllegalArgumentException: too many values to insert >        at > java.lang.invoke.MethodHandleStatics.newIllegalArgumentException(MethodHandleStatics.java:89) >        at > java.lang.in

Limit on number of inserted values in MHs?

2011-05-19 Thread Ola Bini
Hi, I'm currently getting this error: Caused by: java.lang.IllegalArgumentException: too many values to insert at java.lang.invoke.MethodHandleStatics.newIllegalArgumentException(MethodHandleStatics.java:89) at java.lang.invoke.MethodHandles.insertArguments(MethodHandles.java:169