Re: RFR (S) 8025112: JSR 292 spec updates for security manager and caller sensitivity

2013-10-01 Thread John Rose
Chris Thalinger suggested removing the new booleans from the changed "getDirectMethod" call sites and instead put the intended usage into the method names, e.g., "getDirectMethodNoSecurityManager". The result is more clearly correct and maintainable. Here is the respin: http://cr.openjdk.jav

Re: jdk8 metaspace problem with indy

2013-10-01 Thread Jon Masamitsu
On 9/30/13 11:49 AM, Jochen Theodorou wrote: > Am 30.09.2013 17:10, schrieb Stefan Karlsson: > [...] >> First, my experiments were done without --indy so I might be seeing a >> different issue than you are. On the other hand, the experiments shows a >> real problem with our Metaspace and GC intera

RFR (M) 8024438: JSR 292 API specification maintenance for JDK 8

2013-10-01 Thread John Rose
http://cr.openjdk.java.net/~jrose/8024438/webrev.00 These are miscellaneous edits to javadoc and unit tests, clarifying various minor corner cases and improving presentation. There is also a single API change (already under review by CCC): Adding a missing wildcard to Constructor. Please revie

RFR (S) 8025112: JSR 292 spec updates for security manager and caller sensitivity

2013-10-01 Thread John Rose
This change updates the javadoc to reflect previous changes in the behavior of the security manager, especially with respect to caller sensitivity. It also adjusts some unit tests. The key change is to the order of the security manager logic. The purpose is to align the "bytecode behavior" of

Re: RFR (S) 8001105: findVirtual of Object[].clone produces internal error

2013-10-01 Thread John Rose
Second call for reviews. I need two official Reviewers for this change. — John P.S. Thanks for your comments Morris; I enhanced the comment: +// The JVM does this hack also. ++ // (See ClassVerifier::verify_invoke_instructions ++ // and LinkResolver::check_method_accessability.) ++ /