Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

2014-03-26 Thread Igor Ignatyev
Hi Chris, This is very nice. Are there plans to do this for the other existing tests as well? sure, but we didn't have enough time to do it in 8u20 timeframe. So I'd like to push these changes 1st, since we need this to cover 'Speedup catch exceptions'. Other tests will be rewrite later. I h

Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

2014-03-26 Thread Christian Thalinger
On Mar 24, 2014, at 1:33 PM, Igor Ignatyev wrote: > Hi all, > > Please review the patch: > > Problems: > - MethodHandlesTest::testCatchException() doesn't provide enough testing of > j.l.i.MethodHandles::catchException(). > - MethodHandlesTest contains more than 3k lines, an auxiliary code to

Re: RFR (L) 8037210: Get rid of char-based descriptions 'J' of basic types

2014-03-26 Thread Vladimir Ivanov
Here's a version with the new naming scheme: http://cr.openjdk.java.net/~vlivanov/8037210/webrev.03.naming I like existing naming scheme and OBJECT/VOID/LONG/etc names are quite popular(e.g. Wrapper & ASM (Opcodes) use them). So, I'm in favor of leaving it as is. Best regards, Vladimir Ivanov