Typo in CatchExceptionTest.java:
66 private int droped;
Should be “dropped”.
Otherwise seems ok... But more comments would be appreciated. It’s huge and
really hard to understand.
igor
On Mar 28, 2014, at 9:04 AM, Igor Ignatyev wrote:
> Vladimir,
>
> as we'd arranged, I moved ThrowMo
Vladimir,
as we'd arranged, I moved ThrowMode into TestCase and give my word that
I'll
remove TestCase.assertEQ and enhance Asserts.assertEquals for arrays
add the test cases from TestCatchException to 'MANDATORY_TEST_CASES' in
CatchExceptionTest and remove TestCatchException
in JDK9 TF.
upd
Looks good to me.
Best regards,
Vladimir Ivanov
On 3/28/14 8:04 PM, Igor Ignatyev wrote:
Vladimir,
as we'd arranged, I moved ThrowMode into TestCase and give my word that
I'll
remove TestCase.assertEQ and enhance Asserts.assertEquals for arrays
add the test cases from TestCatchException to 'M
Vladimir, thanks for review, please my comments inline.
On 03/28/2014 01:29 PM, Vladimir Ivanov wrote:
Igor, thanks for improving the tests on method handles!
After an offline conversation w/ VladimirI, I've done several changes:
- placed all classes into one file (but I don't like it)
You ca
Igor, thanks for improving the tests on method handles!
After an offline conversation w/ VladimirI, I've done several changes:
- placed all classes into one file (but I don't like it)
You can convert TestCase & TestFactory to inner classes and move
ThrowMode into TestCase since it's usage is co
