Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

2014-03-29 Thread Igor Ignatyev
John, unfortunately, I've already pushed my changes w/o junit annotation. But I have the dirty patch which adds "jtreg support" to netbeans: 1. add test.single action for test folder to 'ide-actions' section in JDK project -- jdk/make/netbeans/j2se/nbproject/project.xml:

Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

2014-03-29 Thread John Rose
On Mar 28, 2014, at 2:29 AM, Vladimir Ivanov wrote: > PS: John mentioned recently that there's a convention for java/lang/invoke > tests to be in JUnit format. I'm not sure it'll improve the code in any way > (maybe TestNG will?). I hope John will express his opinion on this, if it's > import

Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

2014-03-29 Thread Igor Ignatyev
Igor, Thanks for review. Should be “dropped”. fixed But more comments would be appreciated. It’s huge and really hard to understand. sure, I'll add them during future improvements. Igor On 03/29/2014 05:07 AM, Igor Veresov wrote: Typo in CatchExceptionTest.java: 66 private int drope