Re: [9] RFR (XS): 8071787: Don't block inlining when DONT_INLINE_THRESHOLD=0

2015-01-28 Thread John Rose
Good. Consider fixing the typo in 'makeBlockInlningWrapper'. — John On Jan 28, 2015, at 9:12 AM, Vladimir Ivanov wrote: > > http://cr.openjdk.java.net/~vlivanov/8071787/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8071787 > > For testing & performance measurements, sometimes it's us

Re: [9] RFR (XXS): 8071788: CountingWrapper.asType() is broken

2015-01-28 Thread John Rose
Good. On Jan 28, 2015, at 9:22 AM, Vladimir Ivanov wrote: > > The fix is to use adapted MethodHandle to construct LambdaForm. ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

What's the status of / relation between "JEP 169: Value Objects" / "Value Types for Java" / "Object Layout"

2015-01-28 Thread Volker Simonis
Hi everybody, I've recently did some research on Java "value objects" / "value types" / "object layout" (I'll be actually giving a short talk on the topic at FOSDEM[0] this weekend). I just want to quickly summarize my current findings here and gently ask for feedback in case you think I've totall

Re: [9] RFR (M): 8063137: Never-taken branches should be pruned when GWT LambdaForms are shared

2015-01-28 Thread John Rose
On Jan 28, 2015, at 1:00 AM, Vladimir Ivanov wrote: > I polished the change a little according to your comments (diff against v03): > http://cr.openjdk.java.net/~vlivanov/8063137/webrev.03-04/hotspot > +1 Glad to see the AndI

[9] RFR (XXS): 8071788: CountingWrapper.asType() is broken

2015-01-28 Thread Vladimir Ivanov
http://cr.openjdk.java.net/~vlivanov/8071788/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8071788 There's a type mismatch between MethodHandle and LambdaForm in CountingWrapper.asTypeUncached(). Sometimes, it leads to a VM crash. The fix is to use adapted MethodHandle to construct Lambd

[9] RFR (XS): 8071787: Don't block inlining when DONT_INLINE_THRESHOLD=0

2015-01-28 Thread Vladimir Ivanov
http://cr.openjdk.java.net/~vlivanov/8071787/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8071787 For testing & performance measurements, sometimes it's useful to replace block inlining wrappers with trivial reinvokers. This change extends DONT_INLINE_THRESHOLD in the following manner:

Re: [9] RFR (M): 8063137: Never-taken branches should be pruned when GWT LambdaForms are shared

2015-01-28 Thread Vladimir Ivanov
Looking very good, thanks. Ship it! Thanks, John! Actually, can you insert a comment why the injected counts are not scaled? (Or perhaps they should be??) Sure! I intentionally don't scale the counts because I don't see any reason to do so. Profiling is done on per-MethodHandle basis, so th