Roland, thanks a lot for the review!
Best regards,
Vladimir Ivanov
On 4/15/15 7:43 PM, Roland Westrelin wrote:
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.01/
That looks good to me.
Roland.
___
mlvm-dev mailing list
Roland, thanks for looking into the fix!
You are right.
I moved VM_ENTRY_MARK to the beginning of the method [1].
Updated webrev in place.
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.01/
Best regards,
Vladimir Ivanov
[1]
diff --git a/src/share/vm/ci/ciCallSite.cpp
Hi Vladimir,
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.01/hotspot/
In ciCallSite::get_context(), is it safe to manipulate a raw oop the way you do
it (with 2 different oops). Can’t it be moved concurrently by the GC?
Roland.
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.01/
That looks good to me.
Roland.
___
mlvm-dev mailing list
mlvm-dev@openjdk.java.net
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
Now I¹m back from my Easter break I¹ve run done some testing with our
code. Hs-comp is looking good in general, and this code does appear to
give a nice little extra boost. My results are showing a difference at
peak performance, which I found slightly surprising so I¹ll need to take a
look at
Any volunteers to review VM part?
Latest webrev:
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.01/hotspot/
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.01/jdk/
Best regards,
Vladimir Ivanov
On 4/1/15 11:56 PM, Vladimir Ivanov wrote:
Hi Vladimir,
Would it be possible for CallSite.context to hold the Cleaner instance
itself (without indirection through DependencyContext)?
DEFAULT_CONTEXT would then be a Cleaner instance that references some
default Class object (for example DefaultContext.class that serves no
other
On Apr 2, 2015, at 9:17 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
I recommend putting CONTEXT_OFFSET into CallSite, not the nested class.
For one thing, your getDeclaredField call will fail (I think) with a
security manager installed.
You can load it up where TARGET_OFFSET
John,
Thanks for the clarification!
BTW why do you think security manager was the problem? (1)
Class.getDeclaredField() is caller-sensitive; and (2)
DependencyContext was eagerly initialized with CallSite (see
UNSAFE.ensureClassInitialized() in original version).
CallSite$DependencyContext
On 04/01/2015 11:56 PM, Vladimir Ivanov wrote:
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.00/hotspot/
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.00/jdk/
https://bugs.openjdk.java.net/browse/JDK-8057967
Glad to see this finally addressed, thanks!
I did not look through the
Aleksey, thanks a lot for the performance evaluation of the fix!
Best regards,
Vladimir Ivanov
On 4/2/15 7:10 PM, Aleksey Shipilev wrote:
On 04/01/2015 11:56 PM, Vladimir Ivanov wrote:
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.00/hotspot/
John, Peter,
Thanks a lot for the feedback!
Updated webrev:
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.01/hotspot/
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.01/jdk/
Question: How common is state 2 (context-free CS) compared to state 3
(indy-bound CS)?
It's quite rare
On Apr 1, 2015, at 1:56 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.00/hotspot/
http://cr.openjdk.java.net/~vlivanov/8057967/webrev.00/jdk/
https://bugs.openjdk.java.net/browse/JDK-8057967
Impressive work.
Question: How
13 matches
Mail list logo
