Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

2014-09-12 Thread Vladimir Ivanov
Alan, I wasn't aware about such capability. Sounds interesting. Since we are short on time integrating tests for JEP210 into 9 and 8u40, I'd suggest to remove dependency on WB API from the tests for now and file a followup bug to restore it once a suitable solution is found. As I understand,

Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

2014-09-12 Thread Igor Ignatyev
Vladimir/Alan, Yes, only WB.fullGC() is needed, I replaced it w/ System.gc() and removed whitebox from the changes. updated webrev : http://cr.openjdk.java.net/~iignatyev/kshefov/8057707/webrev.00/ Thanks Igor On 09/12/2014 05:41 PM, Vladimir Ivanov wrote: Alan, I wasn't aware about

Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

2014-09-12 Thread Vladimir Ivanov
Looks good. Best regards, Vladimir Ivanov On 9/12/14, 7:03 PM, Igor Ignatyev wrote: Vladimir/Alan, Yes, only WB.fullGC() is needed, I replaced it w/ System.gc() and removed whitebox from the changes. updated webrev : http://cr.openjdk.java.net/~iignatyev/kshefov/8057707/webrev.00/ Thanks

Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

2014-09-11 Thread Vladimir Ivanov
Looks ok. I don't like the idea of having 2 copies of WB API for hotspot and jdk. But that's tolerable unless we have shared location for test libraries in top repository. Having reliable tests is more important IMO. Best regards, Vladimir Ivanov On 9/5/14, 9:57 PM, Konstantin Shefov wrote:

[9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

2014-09-05 Thread Konstantin Shefov
Hello, Please review the change in testlibrary https://bugs.openjdk.java.net/browse/JDK-8057707 This change is needed for new tests for the feature Lambda Form Reduction and Caching https://bugs.openjdk.java.net/browse/JDK-8046703 Webrev of the testlibrary change:

Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

2014-09-05 Thread Alan Bateman
On 05/09/2014 18:57, Konstantin Shefov wrote: Hello, Please review the change in testlibrary https://bugs.openjdk.java.net/browse/JDK-8057707 This change is needed for new tests for the feature Lambda Form Reduction and Caching https://bugs.openjdk.java.net/browse/JDK-8046703 Webrev of the

Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

2014-09-05 Thread Konstantin Shefov
: JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java On 05/09/2014 18:57, Konstantin Shefov wrote: Hello, Please review the change in testlibrary https